From 5a05344d9cd003e5136415fd65a13fd18f28b189 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Povi=C5=A1er?= Date: Fri, 16 Feb 2024 11:41:09 +0100 Subject: [PATCH 1/3] tests: Fix initialization race in xprop tests --- tests/xprop/test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/xprop/test.py b/tests/xprop/test.py index a275b0d93..b73b4dae7 100644 --- a/tests/xprop/test.py +++ b/tests/xprop/test.py @@ -271,7 +271,7 @@ if "prepare" in steps: for pattern in patterns: print( - f' gclk = 1; #0; A[0] = 1\'b{pattern[-1]}; #0; A = {input_width}\'b{pattern}; #5; gclk = 0; $display("%b %b", A, Y); #5', + f' #0; gclk = 1; #0; A[0] = 1\'b{pattern[-1]}; #0; A = {input_width}\'b{pattern}; #5; gclk = 0; $display("%b %b", A, Y); #5', file=tb_file, ) From e51c77484a6d335e431b8e77aa46f3295365025f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Povi=C5=A1er?= Date: Fri, 16 Feb 2024 11:41:53 +0100 Subject: [PATCH 2/3] tests: Comment on `A[0]` --- tests/xprop/test.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/xprop/test.py b/tests/xprop/test.py index b73b4dae7..e2cddf679 100644 --- a/tests/xprop/test.py +++ b/tests/xprop/test.py @@ -270,6 +270,7 @@ if "prepare" in steps: print("initial begin", file=tb_file) for pattern in patterns: + # A[0] might be the clock which requires special sequencing print( f' #0; gclk = 1; #0; A[0] = 1\'b{pattern[-1]}; #0; A = {input_width}\'b{pattern}; #5; gclk = 0; $display("%b %b", A, Y); #5', file=tb_file, From fdda501b587bb1bfc3561979b04a6e323d57677b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Povi=C5=A1er?= Date: Fri, 16 Feb 2024 11:42:56 +0100 Subject: [PATCH 3/3] ci: Stop pinning iverilog revision --- .github/workflows/test-linux.yml | 1 - .github/workflows/test-macos.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/test-linux.yml b/.github/workflows/test-linux.yml index 28c17a6c0..b3a6bd846 100644 --- a/.github/workflows/test-linux.yml +++ b/.github/workflows/test-linux.yml @@ -86,7 +86,6 @@ jobs: run: | git clone https://github.com/steveicarus/iverilog.git cd iverilog - git checkout 192b6aec96fde982e6ddcb28b346d5893aa8e874 echo "IVERILOG_GIT=$(git rev-parse HEAD)" >> $GITHUB_ENV - name: Cache iverilog diff --git a/.github/workflows/test-macos.yml b/.github/workflows/test-macos.yml index 17e2ae331..9b806a580 100644 --- a/.github/workflows/test-macos.yml +++ b/.github/workflows/test-macos.yml @@ -42,7 +42,6 @@ jobs: run: | git clone https://github.com/steveicarus/iverilog.git cd iverilog - git checkout 192b6aec96fde982e6ddcb28b346d5893aa8e874 echo "IVERILOG_GIT=$(git rev-parse HEAD)" >> $GITHUB_ENV - name: Cache iverilog