riscv
/
yosys
mirror of https://github.com/YosysHQ/yosys.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #2428 from whitequark/check-processes 

check: add support for processes
This commit is contained in:
whitequark 2020-11-24 15:04:42 +00:00 committed by GitHub
parent 5cf738b66a d6a93b8b90
commit bc085761e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 55 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

77
passes/cmds/check.cc
View File

@ -35,30 +35,28 @@ struct CheckPass : public Pass {
log("\n"); log("\n");
log("This pass identifies the following problems in the current design:\n"); log("This pass identifies the following problems in the current design:\n");
log("\n"); log("\n");
log(" - combinatorial loops\n"); log(" - combinatorial loops\n");
log("\n"); log(" - two or more conflicting drivers for one wire\n");
log(" - two or more conflicting drivers for one wire\n"); log(" - used wires that do not have a driver\n");
log("\n");
log(" - used wires that do not have a driver\n");
log("\n"); log("\n");
log("Options:\n"); log("Options:\n");
log("\n"); log("\n");
log(" -noinit\n"); log(" -noinit\n");
log(" Also check for wires which have the 'init' attribute set.\n"); log(" also check for wires which have the 'init' attribute set\n");
log("\n"); log("\n");
log(" -initdrv\n"); log(" -initdrv\n");
log(" Also check for wires that have the 'init' attribute set and are not\n"); log(" also check for wires that have the 'init' attribute set and are not\n");
log(" driven by an FF cell type.\n"); log(" driven by an FF cell type\n");
log("\n"); log("\n");
log(" -mapped\n"); log(" -mapped\n");
log(" Also check for internal cells that have not been mapped to cells of the\n"); log(" also check for internal cells that have not been mapped to cells of the\n");
log(" target architecture.\n"); log(" target architecture\n");
log("\n"); log("\n");
log(" -allow-tbuf\n"); log(" -allow-tbuf\n");
log(" Modify the -mapped behavior to still allow $_TBUF_ cells.\n"); log(" modify the -mapped behavior to still allow $_TBUF_ cells\n");
log("\n"); log("\n");
log(" -assert\n"); log(" -assert\n");
log(" Produce a runtime error if any problems are found in the current design.\n"); log(" produce a runtime error if any problems are found in the current design\n");
log("\n"); log("\n");
} }
void execute(std::vector<std::string> args, RTLIL::Design *design) override void execute(std::vector<std::string> args, RTLIL::Design *design) override
@ -100,10 +98,7 @@ struct CheckPass : public Pass {
for (auto module : design->selected_whole_modules_warn()) for (auto module : design->selected_whole_modules_warn())
{ {
if (module->has_processes_warn()) log("Checking module %s...\n", log_id(module));
continue;
log("checking module %s..\n", log_id(module));
SigMap sigmap(module); SigMap sigmap(module);
dict<SigBit, vector<string>> wire_drivers; dict<SigBit, vector<string>> wire_drivers;
@ -111,6 +106,44 @@ struct CheckPass : public Pass {
pool<SigBit> used_wires; pool<SigBit> used_wires;
TopoSort<string> topo; TopoSort<string> topo;
for (auto &proc_it : module->processes)
{
std::vector<RTLIL::CaseRule*> all_cases = {&proc_it.second->root_case};
for (size_t i = 0; i < all_cases.size(); i++) {
for (auto action : all_cases[i]->actions) {
for (auto bit : sigmap(action.first))
if (bit.wire) {
wire_drivers[bit].push_back(
stringf("action %s <= %s (case rule) in process %s",
log_signal(action.first), log_signal(action.second), log_id(proc_it.first)));
}
for (auto bit : sigmap(action.second))
if (bit.wire) used_wires.insert(bit);
}
for (auto switch_ : all_cases[i]->switches) {
for (auto case_ : switch_->cases) {
all_cases.push_back(case_);
for (auto compare : case_->compare)
for (auto bit : sigmap(compare))
if (bit.wire) used_wires.insert(bit);
}
}
}
for (auto &sync : proc_it.second->syncs) {
for (auto bit : sigmap(sync->signal))
if (bit.wire) used_wires.insert(bit);
for (auto action : sync->actions) {
for (auto bit : sigmap(action.first))
if (bit.wire)
wire_drivers[bit].push_back(
stringf("action %s <= %s (sync rule) in process %s",
log_signal(action.first), log_signal(action.second), log_id(proc_it.first)));
for (auto bit : sigmap(action.second))
if (bit.wire) used_wires.insert(bit);
}
}
}
for (auto cell : module->cells()) for (auto cell : module->cells())
{ {
if (mapped && cell->type.begins_with("$") && design->module(cell->type) == nullptr) { if (mapped && cell->type.begins_with("$") && design->module(cell->type) == nullptr) {
@ -216,7 +249,7 @@ struct CheckPass : public Pass {
} }
} }
log("found and reported %d problems.\n", counter); log("Found and reported %d problems.\n", counter);
if (assert_mode && counter > 0) if (assert_mode && counter > 0)
log_error("Found %d problems in 'check -assert'.\n", counter); log_error("Found %d problems in 'check -assert'.\n", counter);