From 6ff5823d6a63bdb093584446ff3983f3c2b38761 Mon Sep 17 00:00:00 2001 From: KrystalDelusion <93062060+KrystalDelusion@users.noreply.github.com> Date: Tue, 26 Nov 2024 09:59:52 +1300 Subject: [PATCH 1/2] test-compile: Use clang-18 and gcc-14 The 'newest' compilers are actually not all that new, they're just the default for the image. Instead provide explicit versions. --- .github/workflows/test-compile.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-compile.yml b/.github/workflows/test-compile.yml index 089e65ca7..f916e9a4c 100644 --- a/.github/workflows/test-compile.yml +++ b/.github/workflows/test-compile.yml @@ -33,8 +33,8 @@ jobs: - 'clang-14' - 'gcc-10' # newest - - 'clang' - - 'gcc' + - 'clang-18' + - 'gcc-14' include: # macOS - os: macos-13 @@ -72,7 +72,7 @@ jobs: # maximum standard, only on newest compilers - name: Build C++20 - if: ${{ matrix.compiler == 'clang' || matrix.compiler == 'gcc'}} + if: ${{ matrix.compiler == 'clang-18' || matrix.compiler == 'gcc-14' }} shell: bash run: | make config-$CC_SHORT From 1e0e367aeda8760407bd8efd81e85580a074ae19 Mon Sep 17 00:00:00 2001 From: KrystalDelusion <93062060+KrystalDelusion@users.noreply.github.com> Date: Tue, 26 Nov 2024 10:18:09 +1300 Subject: [PATCH 2/2] test-compile: Drop back to gcc-13 --- .github/workflows/test-compile.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-compile.yml b/.github/workflows/test-compile.yml index f916e9a4c..74c3e2639 100644 --- a/.github/workflows/test-compile.yml +++ b/.github/workflows/test-compile.yml @@ -32,9 +32,9 @@ jobs: # oldest supported - 'clang-14' - 'gcc-10' - # newest + # newest, make sure to update maximum standard step to match - 'clang-18' - - 'gcc-14' + - 'gcc-13' include: # macOS - os: macos-13 @@ -72,7 +72,7 @@ jobs: # maximum standard, only on newest compilers - name: Build C++20 - if: ${{ matrix.compiler == 'clang-18' || matrix.compiler == 'gcc-14' }} + if: ${{ matrix.compiler == 'clang-18' || matrix.compiler == 'gcc-13' }} shell: bash run: | make config-$CC_SHORT