Merge pull request #2517 from zachjs/sv-tf-implied-direction

sv: complete support for implied task/function port directions
This commit is contained in:
whitequark 2021-01-01 09:31:49 +00:00 committed by GitHub
commit 1a80194cd3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 39 additions and 0 deletions

View File

@ -884,7 +884,11 @@ task_func_args:
task_func_port:
attr wire_type range {
bool prev_was_input = true;
bool prev_was_output = false;
if (albuf) {
prev_was_input = astbuf1->is_input;
prev_was_output = astbuf1->is_output;
delete astbuf1;
if (astbuf2 != NULL)
delete astbuf2;
@ -893,6 +897,12 @@ task_func_port:
albuf = $1;
astbuf1 = $2;
astbuf2 = checkRange(astbuf1, $3);
if (!astbuf1->is_input && !astbuf1->is_output) {
if (!sv_mode)
frontend_verilog_yyerror("task/function argument direction missing");
astbuf1->is_input = prev_was_input;
astbuf1->is_output = prev_was_output;
}
} wire_name |
{
if (!astbuf1) {

View File

@ -0,0 +1,23 @@
module gate(w, x, y, z);
function automatic integer bar(
integer a
);
bar = 2 ** a;
endfunction
output integer w = bar(4);
function automatic integer foo(
input integer a, /* implicitly input */ integer b,
output integer c, /* implicitly output */ integer d
);
c = 42;
d = 51;
foo = a + b + 1;
endfunction
output integer x, y, z;
initial x = foo(1, 2, y, z);
endmodule
module gold(w, x, y, z);
output integer w = 16, x = 4, y = 42, z = 51;
endmodule

View File

@ -0,0 +1,6 @@
read_verilog -sv func_port_implied_dir.sv
hierarchy
proc
equiv_make gold gate equiv
equiv_simple
equiv_status -assert