From 386dbf8c1a66ddd4d1e6f7b978ce59d2c17d4cc4 Mon Sep 17 00:00:00 2001 From: tangxifan Date: Sun, 25 Apr 2021 18:30:48 -0600 Subject: [PATCH 1/2] Update pull_request_template.md --- .../pull_request_template.md | 60 ++++++++++--------- 1 file changed, 31 insertions(+), 29 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index d1c458c04..8bec074e4 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,33 +1,35 @@ ---- -name: Pull request -about: Push a change to this project ---- +> ### Motivate of the pull request +> - [ ] To address an existing issue. If so, please provide a link to the issue: +> - [ ] Breaking new feature. If so, please describe details in the description part. -### Motivate of the pull request -- [ ] To address an existing issue. If so, please provide a link to the issue. -- [ ] Breaking new feature. If so, please decribe details in the description part. +> ### Describe the technical details +> #### What is currently done? (Provide issue link if applicable) +> ** Please provide a list of limitations if not specified in any issue ** +> - [ ] +> - [ ] +> +> #### What does this pull request change? +> ** Please provide a list of highlights of your changes. ** +> - [ ]
+> - [ ] -### Describe the technical details -- What is currently done? (Provide issue link if applicable) -- What does this pull request change? +> ### Which part of the code base require a change +> **In general, modification on existing submodules are not acceptable. You should push changes to upstream.** +> - [ ] VPR +> - [ ] Tileable routing architecture generator +> - [ ] OpenFPGA libraries +> - [ ] FPGA-Verilog +> - [ ] FPGA-Bitstream +> - [ ] FPGA-SDC +> - [ ] FPGA-SPICE +> - [ ] Flow scripts +> - [ ] Architecture library +> - [ ] Cell library +> - [ ] Documentation +> - [ ] Regression tests +> - [ ] Continous Integration (CI) scripts -### Which part of the code base require a change -**In general, modification on existing submodules are not acceptable. You should push changes to upstream.** -- [ ] VPR -- [ ] OpenFPGA libraries -- [ ] FPGA-Verilog -- [ ] FPGA-Bitstream -- [ ] FPGA-SDC -- [ ] FPGA-SPICE -- [ ] Flow scripts -- [ ] Architecture library -- [ ] Cell library +> ### Impact of the pull request -### Checklist of the pull request -- [ ] Require code changes. -- [ ] Require new tests to be added -- [ ] Require an update on documentation - -### Impact of the pull request -- [ ] Require a change on Quality of Results (QoR) -- [ ] Break back-compatibility. If so, please list who may be influenced. +> - [ ] Require a change on Quality of Results (QoR) +> - [ ] Break back-compatibility. If so, please list who may be influenced. From deb9f4a9f78990276a5a4051304c5d43a6284b79 Mon Sep 17 00:00:00 2001 From: tangxifan Date: Sun, 25 Apr 2021 22:11:34 -0600 Subject: [PATCH 2/2] Update pull_request_template.md --- .../pull_request_template.md | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 8bec074e4..f1b1063fd 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -4,17 +4,21 @@ > ### Describe the technical details > #### What is currently done? (Provide issue link if applicable) -> ** Please provide a list of limitations if not specified in any issue ** -> - [ ] -> - [ ] +> +> +> +> +> > > #### What does this pull request change? -> ** Please provide a list of highlights of your changes. ** -> - [ ]
-> - [ ] +> +> +> +> +> > ### Which part of the code base require a change -> **In general, modification on existing submodules are not acceptable. You should push changes to upstream.** +> > - [ ] VPR > - [ ] Tileable routing architecture generator > - [ ] OpenFPGA libraries