riscv
/
OpenFPGA
mirror of https://github.com/lnis-uofu/OpenFPGA.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix the cpp-format

This commit is contained in:
Chung Shien Chai 2023-07-16 13:08:40 -07:00
parent 161cafddfc
commit b2f5b493c2
1 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
libs/libopenfpgautil/src/openfpga_decode.cpp
View File

@ -5,6 +5,7 @@
/* Headers from vtrutil library */
#include "openfpga_decode.h"
#include "vtr_assert.h"
/* begin namespace openfpga */
@ -108,14 +109,14 @@ std::string combine_two_1hot_str(const std::string& code1,
* Output:
* index | 0 | 1 | 2
* ret | 0 | 0 | 1
*
* ToDo: Need to revisit and change all the feature that call to this function
* Had studied the code, should be safe to make the change
* Apparently we only want to store 0 or 1 (binary vector)
* Yet we store it in a vector on size_t (8 Bytes)
* We are using 8x memory that we supposed to
* uint8_t is good enough
* Not a bug, but is a serious unoptimized issue
*
* ToDo: Need to revisit and change all the feature that call to this function
* Had studied the code, should be safe to make the change
* Apparently we only want to store 0 or 1 (binary vector)
* Yet we store it in a vector on size_t (8 Bytes)
* We are using 8x memory that we supposed to
* uint8_t is good enough
* Not a bug, but is a serious unoptimized issue
********************************************************************/
std::vector<size_t> itobin_vec(const size_t& in_int, const size_t& bin_len) {
/* bin_len must be in valid range*/
@ -123,9 +124,10 @@ std::vector<size_t> itobin_vec(const size_t& in_int, const size_t& bin_len) {
std::vector<size_t> ret(bin_len, 0);
/* Make sure we do not have any overflow! */
/* If the length is 64 bits, in_int can be any number since this is the max bit length, and BTW pow(2, 64)
itself should be zero (from 64bits size_t perspective). Once we fix the bintoi_charvec() bug, without
this change, it will cause assertion */
/* If the length is 64 bits, in_int can be any number since this is the max
bit length, and BTW pow(2, 64) itself should be zero (from 64bits size_t
perspective). Once we fix the bintoi_charvec() bug, without this change, it
will cause assertion */
if (bin_len < 64) {
VTR_ASSERT(in_int < (size_t(1) << bin_len));
}
@ -159,9 +161,10 @@ std::vector<char> itobin_charvec(const size_t& in_int, const size_t& bin_len) {
std::vector<char> ret(bin_len, '0');
/* Make sure we do not have any overflow! */
/* If the length is 64 bits, in_int can be any number since this is the max bit length, and BTW pow(2, 64)
itself should be zero (from 64bits size_t perspective). Once we fix the bintoi_charvec() bug, without
this change, it will cause assertion */
/* If the length is 64 bits, in_int can be any number since this is the max
bit length, and BTW pow(2, 64) itself should be zero (from 64bits size_t
perspective). Once we fix the bintoi_charvec() bug, without this change, it
will cause assertion */
if (bin_len < 64) {
VTR_ASSERT(in_int < (size_t(1) << bin_len));
}