d1a1e0e529
Adjust scaling when session size changes
...
Session size changes can be initiated from the server, and not just
from the client. Make sure we update the scaling when this happens.
2017-08-16 11:00:04 +02:00
858ea4a774
Avoid use of 'let' and 'const'
...
They are not supported on older browsers, e.g. iOS 9.
2017-06-02 15:41:37 +02:00
bbc1648c7a
Add hint that the control bar can be moved
...
The control bar can be dragged to the other side, this isn't obvious
however. This adds a hint on the opposite side in the form of a subtle
glowing half-ellipse.
2017-05-29 15:57:13 +02:00
c23665dd82
Clear the password input field
...
If a user disconnects but leaves the browser tab open, the password
input field would still contain the password for future connections.
We now clear the input field after reading the password into memory.
2017-05-20 19:05:46 +02:00
55988e7aec
Fix bootstart of input field
...
It wasn't working properly anymore because it expected to be triggered
by the "load". But we now register that event listener long after the
"load" event has already fired.
2017-05-15 14:42:28 +02:00
d4fc89d8b9
Catch errors for when we can't play bell
...
Many browsers, for example Chrome on Android will not allow audio to
play unless it's initiated from a user action. It is not reasonable to
display an error for this. Fixes issue #821 .
2017-05-12 12:52:05 +02:00
7ca650b73d
Add missing semi colon
2017-05-12 08:48:41 +02:00
333ad45c70
Don't capture touch events
...
They are implicitly captured anyway, and we get problems if we try
to explicitly capture them.
2017-05-11 13:34:43 +02:00
26586b9ddf
Remove colour map support
...
It was broken and unused. Remove it so we can simplify the code.
2017-05-04 15:13:33 +02:00
545442afc3
Merge branch 'keyboard' of https://github.com/CendioOssman/noVNC
2017-05-04 12:18:55 +02:00
94f5cf05f3
Send keyboard events from single place
...
This makes it easier to handle any needed variations, like different
types of messages.
2017-05-04 12:13:47 +02:00
41c958d450
Properly restore the default style
...
Setting a style to null does restore it in FF, Chrome, Safari and Edge.
But it does not work in Internet Explorer. The proper way to restore to
default values is to set it to the empty string. This works in all
browsers. Fixes issue #808 .
2017-04-11 10:57:21 +02:00
524d67f283
Remove keysym names from keysymdef.js
...
They were incomplete and turned off in most cases so they served
little use besides adding complexity.
2017-03-24 11:16:53 +01:00
adfc9d3f54
Move error handler into separate file
...
This commit moves the global error handler into a separate file,
so that it can catch module loading errors.
This also adds support for properly displaying error messages with
newlines in them (since the module loader may throw those)
2017-03-21 17:39:07 -04:00
e6a8eb15ca
Only apply settings with an RFB object
...
We should only apply settings if we have an RFB object available.
Some of the settings handlers didn't respect this, but do now.
2017-03-21 17:39:07 -04:00
e25f9c4010
Use transition animation while loading
...
This shows the transition animation while loading, so users can see
something is going on.
2017-03-21 17:39:07 -04:00
6d6f0db0da
Refactor ES6 module structure/split up Util
...
This commit restructures many of the ES6 modules, splitting them
up to actual export multiple functions instead of a single object.
It also splits up Util into multiple sub-modules, to make it easier
to maintain.
Finally, localisation is renamed to localization.
2017-03-21 17:39:05 -04:00
2a7c6d20ab
Load translations over XHR
...
This commit causes translations to be loaded over XHR instead of
the import system.
2017-03-07 11:11:29 -05:00
3ae0bb0968
Uncomment ES6 module syntax
...
This removes the special comment part of the ES6 module syntax,
opting to enable ES6 module syntax by default.
It also appends `.js` to all import paths to better support in-browser
loading.
2017-02-26 16:30:37 -05:00
d55e454582
Fix typos in imports and i18n
...
`app/ui.js` had an incorrect import path which caused issues
when using the ES6 and/or CommonJS builds of noVNC.
`core/util.js` had a non-strict-compatible declaration of a variable
without a `let` or `var` (it now uses `let`).
This fixes both issues.
2017-02-26 16:30:37 -05:00
b56d975248
Merge branch 'settingswhileconnected' of https://github.com/samhed/noVNC
...
Closes pull request #778
2017-02-24 15:42:27 +01:00
24584cca89
Disable labels for settings as well
...
Makes the settings UI easier to read.
2017-02-21 11:58:03 +01:00
fb49f91b00
Allow local cursor to be changed while connected
2017-02-19 01:53:41 +01:00
3a535adab0
Allow auto reconnect to be changed while connected
2017-02-19 01:53:41 +01:00
ef1e8bab22
Allow view_only to be changed while connected
2017-02-19 01:53:41 +01:00
0298305e80
Allow clipping to be changed while connected
2017-02-18 16:30:35 +01:00
e677b66cc7
Proper workaround for Chrome's scrollbar bug
...
Avoid applying this workaround more than necessary. Also comment a
bit more why this hack is needed.
2017-02-16 16:28:55 +01:00
b56772ec43
Update drag button at right time
...
It needs to update whenever the viewport or clipping changes, so
let's make sure that actually happens and not trigger on mildly
related events.
2017-02-16 16:07:55 +01:00
6bfd9dc96f
Update clipping before changing scaling
...
The scaling is relative the current viewport, so we need to make
sure it is correct before changing the scale setting.
2017-02-16 16:07:55 +01:00
5f38376adb
Don't change stored setting when "forcing"
...
Don't overwrite the user's configured choice. Instead ignore
settings when they cannot be respected.
2017-02-16 16:07:55 +01:00
631428d966
Fix status class for IE
...
IE apparently doesn't support removing several class specifiers at
once, so switch to several calls.
2017-02-16 16:07:55 +01:00
b18ef8162e
Allow scroll bars on Safari and IE
...
The previous problems were because we were scrolling the wrong element,
so we can enable this feature now.
2017-02-16 16:07:40 +01:00
280676c7e9
Properly encapsulate the scale in Display
...
Other parts of the code shouldn't have to care about this. Let Display
convert between canvas coordinates and framebuffer coordinates.
2017-02-16 14:00:39 +01:00
bd7d89e7cc
Fix resize on Chrome
...
Chrome sucks at calculating the size and gets confused due to the
scrollbars. Hide the scroll bars while resizing.
2017-02-10 16:39:18 +01:00
86d15a4929
Use setCapture() polyfill everywhere
...
This makes sure we get consistent behaviour across all browsers.
2017-02-09 15:51:22 +01:00
b345859ed6
More aggressive retaining of focus
...
Try to keep the virtual keyboard up even more. Only release focus
when it is absolutely necessary.
2017-02-09 14:20:37 +01:00
84b05d24b0
Allow submitting the password from the input field
2017-02-03 13:19:15 +01:00
648c83984c
Scroll correct element
...
The element we want scrolling around is noVNC_screen, not the entire
window. This also allows us to compute the screen size without
fiddling the scrollbars on and off.
2017-02-03 13:17:43 +01:00
623b1b7d96
Allow resize setting to be changed while connected
...
There is no reason to why this shouldn't be possible.
2017-01-27 16:22:15 +01:00
59387b34ea
Separate init functions from event handling setup
...
Adds a new section for all functions that add event handlers.
2017-01-27 16:20:53 +01:00
3fdc69ceda
Rename function for adding resize handlers
...
Moves the one handler for the status out of the function as well. It
didn't fit in with the function's old name either.
2017-01-27 16:20:53 +01:00
b3d91b78e1
Rename and move init function for fullscreen
2017-01-27 16:20:53 +01:00
dceda58642
Save settings immediately
...
Retire the old settingsApply. This also allows UI logic to check the
state of things using the settings instead of having to look at the
values of HTML elements (we couldn't be sure if the changes were
applied yet or not).
2017-01-27 16:20:33 +01:00
0b09e9cb6f
Remove unused toggleConnectPanel function
2017-01-24 14:37:14 +01:00
aa90547519
Add UI wrapper for Webutil.init_logging
2017-01-24 14:36:19 +01:00
394ad22be9
Merge branch 'add-reconnect' of https://github.com/fd0/noVNC
2017-01-23 13:47:57 +01:00
044d54ed62
Add reconnect option
...
Add an option to automatically reconnect after a delay when the
connection is closed.
Closes #746
2017-01-23 11:42:41 +01:00
413ea87741
Fix global error handler
...
It stopped working when we switched to textContent as it relies
on being able to add new HTML elements. Do things properly by
adding new elements via createElement().
2017-01-18 15:59:31 +01:00
6048299a13
Use textContent instead of innerHTML
...
Previously, setting `innerHTML` was used to display the statuses. These
could include content communicated from the remote VNC server, allowing
the remove VNC server to inject HTML into the noVNC page.
This commit switches all uses of `innerHTML` to use `textContent`, which
is not vulnerable to the HTML injection.
2017-01-12 14:47:36 -05:00
b3c932c386
Make connect button more prominent
...
It's generally the only thing the user needs to click on, so make
sure it clearly stands out.
2017-01-04 15:05:58 +01:00
512d3605ad
Remove connect dialog
...
It only contained a password field, which might not be needed, and
is handled by a separate dialog if it is.
2017-01-04 15:05:01 +01:00
575f69832d
Group WebSocket settings together
...
It was easy to confuse them as being VNC settings, so keep them all
under one group.
2017-01-04 15:05:01 +01:00
340d9d66cc
Remove alternative style sheets
...
Anyone with basic knowledge of CSS will easily figure out how to
customise the appearance of the UI, so remove the burden of having
to maintain these extra style sheets.
2017-01-04 15:05:01 +01:00
58fc267b2b
Remove unused token setting
2017-01-04 15:05:01 +01:00
c01b2f0259
Merge pull request #699 from CendioOssman/double
...
Display double buffering
2016-12-13 12:42:22 +01:00
adf345fdc4
Clean up viewport handling
...
Make sure the viewport is properly updated when necessary, on respects
given restrictions.
2016-12-09 09:20:50 +01:00
3f781f2aa3
Remove max dimension handling
...
The viewport handling is now a lot clearer, so simply limit the size
of the viewport in the caller rather than having this extra layer
of checks.
2016-12-09 09:20:50 +01:00
18d21e3621
Update all state on session size change
2016-12-09 09:20:50 +01:00
a8cc32d8b9
Merge pull request #725 from CendioOssman/rightbar
...
Allow control bar to be moved to the right side
2016-11-29 13:23:02 +01:00
d062074b5a
Clear UI.connected state variable right away
...
Keeping it set for the disconnecting state was causing an issue where
the controlbar could be hidden without any way to open it, when a
session disconnects too quickly.
2016-11-28 12:36:29 +01:00
d8ff7c9ed6
Further fixes for fallback error handler
...
Layout improvements as well as an check for ErrorEvent.error as it is
not standardized.
2016-11-28 12:33:42 +01:00
38d8cfdf83
Fix fallback error handling
...
Start using the correct API for window.addEventListener('error',..).
Unlike when using onerror, the handler function gets an event.
2016-11-28 10:02:13 +01:00
cf348b7892
Remember control bar position
2016-11-26 15:26:28 +01:00
8ee432f1db
Allow control bar to be moved to the right side
2016-11-26 15:13:33 +01:00
de315d6216
Touching the handle should keep the control bar visible
...
Calling stopPropagation() was causing the normal event listeners
to never get the proper events.
2016-11-24 17:03:47 +01:00
f5bf2d84ef
Merge pull request #718 from ossman/po
...
Use gettext .po files, and translate everything
2016-11-22 21:02:13 +01:00
1983baf5bf
Fix link tagname
2016-11-21 13:43:02 +01:00
edffd9e2f8
Also translate HTML elements
2016-11-19 13:23:00 +01:00
3cdc603aa4
Use gettext .po files for translations
...
This allows the same workflow as most other projects for translations.
2016-11-17 20:42:08 +01:00
45729def6d
Restore translations for some strings
...
We lost the translation calls for a couple of strings in one of
the clenaups.
2016-11-17 19:58:10 +01:00
f28e248d3f
Use _() as shorthand for translations
...
Used commonly when gettext is used for translations. Avoids cluttering
the code.
2016-11-17 19:58:10 +01:00
d24de750b1
Add fallback handling for uncought errors
2016-11-10 14:33:23 +01:00
b85a13de69
Merge pull request #689 from ossman/keysym
...
Don't send Unicode as keysym
2016-11-10 09:36:43 +01:00
f3d25df048
Merge pull request #711 from CendioOssman/spinners
...
Blocking transition screen when connecting/disconnecting
2016-11-10 08:47:23 +01:00
8d710e8b18
Blocking transition screen when connecting/disconnecting
2016-11-08 14:54:48 +01:00
37ebc5c14e
Merge pull request #697 from CendioOssman/keyboard
...
Better method to keep focus on virtual keyboard
2016-11-08 12:28:23 +01:00
fdb02f8570
Always translate literals instead of variables
...
Makes it much easier to find what needs to be translated.
2016-10-28 15:41:08 +02:00
91e41150f0
Don't translate unexpected errors
2016-10-28 15:41:00 +02:00
a93cda3a36
Move app-specific location of language files
...
The core directory should only contain core API code that isn't
specific to an application.
2016-10-28 14:30:14 +02:00
5af39a878a
Added localization to statusbar
2016-10-28 12:40:28 +02:00
2e5cae1b23
Update comment for screenSize()
...
The explanation was outdated.
2016-10-24 14:26:53 +02:00
1a15f22905
Remove unnecessary anonymous function
...
addEventListener can handle multiple assigned events, no need for a
wrapping function.
2016-10-24 14:08:53 +02:00
4770b0c311
Typo fix for last commit
...
Commit 7d20158b4b
2016-10-24 13:59:35 +02:00
7d20158b4b
Add missing log output for UI-specific errors
...
Some UI errors and one warning didn't write to the log. We want all
errors to be logged.
2016-10-24 13:36:05 +02:00
daca5b1727
Reformat lines to avoid line-breaks
2016-10-24 13:35:06 +02:00
ffcadf9507
Better method to keep focus on virtual keyboard
...
This prevents the focus being lost rather than trying to restore it
at various places.
2016-10-21 16:27:43 +02:00
ac33960368
Merge pull request #649 from kanaka/dontgrabinviewonly
...
Fix view only
2016-10-20 01:04:14 +02:00
5826ab6f6a
Merge pull request #650 from kanaka/touchdetect
...
New way of detecting touch
2016-10-20 00:18:32 +02:00
8473635a09
Fix typo that caused clipping by default on IE
...
Typo from commit a6357e8276
2016-10-19 15:33:06 +02:00
f75e4d3caa
Add safety check in code for moving the handle
...
An element that has 'display: none' has a height of zero, and the logic
for the handle assumed that this was never the case. This could cause
the handle to end up at the wrong coordinates.
2016-10-18 13:32:00 +02:00
59cd99bc38
Move the handle properly when page is scrolled
...
The coordinates used to calculate the position for the toolbar handle
wrongly took page-offset into account. Util.getPosition was being used
for this. Thus, when page was scrolled, this caused the handle to be
offset when it was being moved. Use getBoundingClientRect instead.
2016-10-18 13:26:17 +02:00
0b96eddf56
Don't send Unicode to RFB.sendKey()
...
The argument must be a Keysym, not a Unicode codepoint.
2016-10-15 14:58:59 +02:00
bea2b3fdfc
New way of detecting touch
...
Moves detection to Util and fixes so that touch is properly detected on
MS Surface and touch emulation in Chrome.
2016-10-14 02:41:06 +02:00
eef91bf9e3
Hide input related buttons in view only
2016-10-14 01:46:55 +02:00
ceb847b0e3
Don't modify mouse or keyboard in view_only mode
...
The UI previously didn't respect view_only in a number of cases.
2016-10-14 01:46:55 +02:00
301dc0e20b
Add logging when creation of RFB fails
2016-10-14 01:46:55 +02:00
7ae53db9cd
Don't request a new desktop size in view_only
2016-10-14 01:46:55 +02:00
da346c3b21
Remove redeclaration of a variable
2016-10-13 14:57:37 +02:00
00df30999b
Merge pull request #651 from kanaka/separatestates
...
Separate visual state from protocol state
2016-10-01 10:20:01 +02:00
ca99791caa
Merge pull request #665 from CendioOssman/bell
...
Support RFB bell
2016-09-30 19:37:09 -04:00
4102b71c33
Keep the connect panel when missing host or port
2016-10-01 01:34:31 +02:00
74a4a2b468
Do not timeout error messages
2016-10-01 01:34:31 +02:00
7520ba52d8
Don't close the control bar when disconnected
...
If you were very quick to disconnect, you could end up in a state
where the toolbar was hidden.
2016-10-01 01:34:31 +02:00
3bb12056b1
Remove unnecessary substates of disconnected
...
The states 'loaded', 'failed' and 'fatal' were all variations of the
'disconnected' state. Removing these states allows us to get rid of
many ugly workarounds and special cases. Error messages to the UI can
now instead be delivered via a new onDisconnected callback.
2016-10-01 01:34:25 +02:00
c2a4d3ef86
Improve the connection state names
...
Names such as 'disconnect' and 'disconnected' are inconsistent in the
way that one describes an action and the other a state. The state that
was called 'normal' didn't fit in with the others because the other
names describe a connection state. The new names are: 'disconnecting',
'connecting' and 'connected'
2016-10-01 01:30:02 +02:00
a7127fee73
Don't abuse state change function for messages
...
This doesn't even work anymore since we fixed it to ignore changes
to the current state. Add a separate callback for notifications
instead.
2016-10-01 01:29:44 +02:00
7d714b15f5
Remove special password state
...
We already have a callback mechanism for this, so let's use that.
Adds an optional parameter 'msg' to the callback.
Fixes vnc_auto.html (#646 ) which was broken after
4e0c36dda7
2016-10-01 00:02:47 +02:00
1c1cc1d0e9
Use single line if's for simple return criteria
2016-09-30 21:55:49 +02:00
4b30f9ce09
Clean up virtual keyboard handling
2016-09-23 17:45:25 +02:00
ca25d2ae26
Move Ctrl+Alt+Del to extra keys menu
...
The extra keys menu is now present for all devices, so avoid clutter
by moving the Ctrl+Alt+Del button there as well.
2016-09-23 14:39:21 +02:00
3f93a385a2
Auto-close the toolbar on connect after a delay
2016-09-23 14:39:21 +02:00
04b399e27d
Allow moving the controlbar handle
...
This also adds emulation of Element.setCapture() as only Firefox
and Internet Explorer/Edge currently supports it.
2016-09-23 14:39:21 +02:00
38323d4d92
Add handle to open and close the control bar
2016-09-23 14:39:21 +02:00
728b5d9e1a
Make control bar transparent when idle
2016-09-23 14:39:21 +02:00
fb7c3b3be2
Change control bar to a smaller left-side toolbar
2016-09-23 14:39:21 +02:00
6244e383e4
Let CSS update UI for touch and connected state
...
Avoid a lot of JavaScript code that can easily be handed using
style sheets instead, specifically items that should only be shown
when on a touch device, or items that depend on the connected state.
2016-09-23 14:39:21 +02:00
ebbec43a6b
Enable extra keys for all devices
...
Manual special keys can be useful on all devices, so stop restricting
it to just touch devices.
2016-09-23 14:39:21 +02:00
8a7ec6ea19
Add a separate dialog for the password prompt
...
The user might be queried for the password during the connect stage
if no password was previously provided. Add a separate dialog for
this rather than abusing the connect dialog.
2016-09-23 14:39:21 +02:00
8d7708c82e
Abstract status dialog CSS class handling
2016-09-23 14:39:21 +02:00
b0c6d3c6aa
Remove redundant modifier state variables
2016-09-23 14:39:17 +02:00
ca5c74ad5a
Show all status messages in a popup top bar
2016-09-23 14:22:16 +02:00
63bf2ba578
Support RFB bell
...
The protocol handling was already there. What was missing was
hooking it up to a sound file in the user interface.
2016-09-22 11:15:42 +02:00
ed8cbe4e7b
Clean up panel open/close API
2016-09-20 15:37:19 +02:00
d9e8621436
Make "selected" an extra CSS class
...
Avoid duplicating stuff in the style sheet by making the "selected"
property an extra class, rather than a replacement for the base one.
2016-09-20 15:36:42 +02:00
a49d929846
Harmonise CSS names
...
Follow the same naming convention for all CSS ids and classes.
2016-09-20 15:36:38 +02:00
e40978c7fc
Let CSS control what it means to be hidden/closed
...
This avoids hard-coding layout information in the JavaScript code.
It also opens up possibilities for more control in the CSS, e.g. for
animation.
2016-09-20 14:32:57 +02:00
6cba147d4e
Simplify modifier button display
2016-09-19 16:27:55 +02:00
999f1d45db
Show/hide logo in updateVisualState()
...
We control the visibility of almost everything else in this function,
so move the logo handling there as well.
2016-09-19 16:26:23 +02:00
f9fff03719
Remove unused description
2016-09-19 16:24:39 +02:00
f0d9ab9698
Avoid ambigious optional arguments
...
Some functions weren't obvious what they would do if an argument was
omitted. Split them up in to separate functions in those cases to
make the API clearer.
2016-09-19 16:19:45 +02:00
3e3eec28f3
Remove beforeunload handler
...
Support for this is spotty and it is getting more and more restricted
by the day. Give up on this approach.
2016-09-19 16:16:32 +02:00
0f6af1e3ec
Separate UI.start() in to sub-functions
2016-09-19 16:16:05 +02:00
d7f790719a
Add events to objects the modern way
...
The old way only allows a single event handler per event, so switch
over everything to the new model.
2016-09-19 15:58:21 +02:00
bfa414e5e8
Remove unused event handlers
...
These do not work and the mechanism for releasing keyboard grab on
the settings panel needs more work.
2016-09-19 15:40:10 +02:00
17eb0fcf50
Trigger autoconnect at proper time
...
It needs to happen after everything is fully initialised.
2016-09-19 15:30:40 +02:00
bd5340c7ee
Move input-related files into core/input
...
This commit moves all the input-related files from `core/`
to `core/input/`, and renames a couple as relevant
(input.js --> input/devices.js, keyboard.js --> input/util.js).
2016-09-16 15:49:52 -04:00
b4ef49ea36
Remove unecessary event-related code from Util
...
The event-related wrapper functions in Util existed mainly for
backwards-compat. However, all currently supported browsers
support the standard functions, so these wrappers are no longer needed.
2016-09-16 15:49:52 -04:00
72bdd06ea2
Clean up Util
...
This commit removes unused code from Util, and moves the script-loading
functionality to WebUtil.
2016-09-16 15:49:52 -04:00
ae510306b5
Enable noVNC to become Browserifiable
...
This commit restructures noVNC, splitting it into the core directory
and the app directory, with the former containing core noVNC parts,
and the latter containing parts specific to the application.
2016-09-16 15:49:51 -04:00
Pierre Ossman
Samuel Mannehed
Solly Ross
Alexander Neumann
Pierre Ossman
Loek Janssen
Solly Ross