diff --git a/include/canvas.js b/include/canvas.js index 3b9cde5b..41d94591 100644 --- a/include/canvas.js +++ b/include/canvas.js @@ -31,18 +31,20 @@ var that = {}, // Public API interface c_mouseMove = null; -// Capability settings, default can be overridden -Util.conf_default(conf, that, 'prefer_js', null); -Util.conf_default(conf, that, 'cursor_uri', null); - // Configuration settings -Util.conf_default(conf, that, 'target', null); -// Area that traps keyboard input -Util.conf_default(conf, that, 'focusContainer', document); -Util.conf_default(conf, that, 'true_color', true); -Util.conf_default(conf, that, 'focused', true); -Util.conf_default(conf, that, 'colourMap', []); -Util.conf_default(conf, that, 'scale', 1); +function cdef(v, type, defval, desc) { + Util.conf_default(conf, that, v, type, defval, desc); } + +// Capability settings, default can be overridden +cdef('prefer_js', 'raw', null, 'Prefer Javascript over canvas methods'); +cdef('cursor_uri', 'raw', null, 'Can we render cursor using data URI'); + +cdef('target', 'dom', null, 'Canvas element for VNC viewport'); +cdef('focusContainer', 'dom', document, 'DOM element that traps keyboard input'); +cdef('true_color', 'bool', true, 'Request true color pixel data'); +cdef('focused', 'bool', true, 'Capture and send key strokes'); +cdef('colourMap', 'raw', [], 'Colour map array (not true color)'); +cdef('scale', 'float', 1, 'VNC viewport scale factor'); // Override some specific getters/setters that.set_prefer_js = function(val) { diff --git a/include/default_controls.js b/include/default_controls.js index 7840e434..2864ee71 100644 --- a/include/default_controls.js +++ b/include/default_controls.js @@ -49,6 +49,8 @@ load: function(target) { html += ' type="checkbox" checked> True Color'; html += '
  • > externalUpdateState stub"); }); -// clipboard contents received callback -Util.conf_default(conf, that, 'clipboardReceive', function () { - Util.Debug(">> clipboardReceive stub"); }); +cdef('updateState', + 'func', function() { Util.Debug("updateState stub"); }, + 'callback: state update'); +cdef('clipboardReceive', + 'func', function() { Util.Debug("clipboardReceive stub"); }, + 'callback: clipboard contents received'); // Override/add some specific getters/setters @@ -426,7 +422,7 @@ updateState = function(state, statusMsg) { connTimer = setTimeout(function () { updateState('failed', "Connect timeout"); - }, conf.connectTimeout); + }, conf.connectTimeout * 1000); init_vars(); init_ws(); @@ -437,9 +433,11 @@ updateState = function(state, statusMsg) { case 'disconnect': - disconnTimer = setTimeout(function () { - updateState('failed', "Disconnect timeout"); - }, conf.disconnectTimeout); + if (! test_mode) { + disconnTimer = setTimeout(function () { + updateState('failed', "Disconnect timeout"); + }, conf.disconnectTimeout * 1000); + } // WebSocket.onclose transitions to 'disconnected' break; @@ -526,7 +524,7 @@ function handle_message() { } recv_message = function(e) { - //Util.Debug(">> recv_message"); + //Util.Debug(">> recv_message: " + e.data.length); try { decode_message(e.data); diff --git a/include/util.js b/include/util.js index b67391d1..91883f48 100644 --- a/include/util.js +++ b/include/util.js @@ -131,10 +131,9 @@ Util.getQueryVar = function(name, defVal) { }; // Set defaults for Crockford style function namespaces -Util.conf_default = function(cfg, api, v, val, force_bool) { - if (typeof cfg[v] === 'undefined') { - cfg[v] = val; - } +Util.conf_default = function(cfg, api, v, type, defval, desc) { + // Description + api['get_' + v + '_desc'] = desc; // Default getter if (typeof api['get_' + v] === 'undefined') { api['get_' + v] = function () { @@ -144,16 +143,26 @@ Util.conf_default = function(cfg, api, v, val, force_bool) { // Default setter if (typeof api['set_' + v] === 'undefined') { api['set_' + v] = function (val) { - if (force_bool) { + if (type in {'boolean':1, 'bool':1}) { if ((!val) || (val in {'0':1, 'no':1, 'false':1})) { val = false; } else { val = true; } + } else if (type in {'integer':1, 'int':1}) { + val = parseInt(val, 10); } cfg[v] = val; }; } + + if (typeof cfg[v] === 'undefined') { + // Set to default + api['set_' + v](defval); + } else { + // Coerce existing setting to the right type + api['set_' + v](cfg[v]); + } };