From f2d42dc3577d921ac8f51c029729b3fca275c483 Mon Sep 17 00:00:00 2001 From: Pierre Ossman Date: Mon, 14 Oct 2019 10:15:19 +0200 Subject: [PATCH] Never show drag icon if clipping is disabled Toggling the enabled state is a remnant from an earlier version of the code where we could determine if the the session is actually clipped, and not just that the setting is enabled. Right now we only change things based on the setting, so let's completely hide the button when clipping is disabled. --- app/ui.js | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/app/ui.js b/app/ui.js index e5cd13ae..0148a440 100644 --- a/app/ui.js +++ b/app/ui.js @@ -1299,24 +1299,10 @@ const UI = { viewDragButton.classList.remove("noVNC_selected"); } - // Different behaviour for touch vs non-touch - // The button is disabled instead of hidden on touch devices - if (isTouchDevice) { + if (UI.rfb.clipViewport) { viewDragButton.classList.remove("noVNC_hidden"); - - if (UI.rfb.clipViewport) { - viewDragButton.disabled = false; - } else { - viewDragButton.disabled = true; - } } else { - viewDragButton.disabled = false; - - if (UI.rfb.clipViewport) { - viewDragButton.classList.remove("noVNC_hidden"); - } else { - viewDragButton.classList.add("noVNC_hidden"); - } + viewDragButton.classList.add("noVNC_hidden"); } },