jcarr
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use wss when creating localhost connection to detect binary support 

Some browsers (Firefox) reject unencrypted ws connections if the hosting
page uses https by throwing an exception when you create the websocket
object.

NoVNC interprets this as binary being unsupported, and falls back to
base64.

If we instead connect to wss://localhost, the websocket object can be
created regardless of whether the hosting page is on http or https.
This commit is contained in:
jalf 2013-04-05 13:45:27 +02:00
parent c2b1409a43
commit ec34af8f61
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/websock.js
View File

@ -282,7 +282,7 @@ function init(protocols) {
// TODO: this sucks, the property should exist on the prototype // TODO: this sucks, the property should exist on the prototype
// but it does not. // but it does not.
try { try {
if (bt && ('binaryType' in (new WebSocket("ws://localhost:17523")))) { if (bt && ('binaryType' in (new WebSocket("wss://localhost:17523")))) {
Util.Info("Detected binaryType support in WebSockets"); Util.Info("Detected binaryType support in WebSockets");
wsbt = true; wsbt = true;
} }