From acca6487f2eaef58b2829c31cbee14c25ca7747c Mon Sep 17 00:00:00 2001 From: Pierre Ossman Date: Tue, 29 Nov 2016 14:48:34 +0100 Subject: [PATCH 1/2] Update test platforms Test on the latest version of everything, as new versions are coming out constantly. Also add some missing combinations. --- .travis.yml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 243df3f2..a7fe4233 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,12 +8,10 @@ node_js: env: matrix: - TEST_BROWSER_NAME=PhantomJS - - TEST_BROWSER_NAME=chrome TEST_BROWSER_OS='Windows 7,Linux' - - TEST_BROWSER_NAME=firefox TEST_BROWSER_OS='Windows 7,Linux' TEST_BROWSER_VERSION='30,26' - - TEST_BROWSER_NAME='internet explorer' TEST_BROWSER_OS='Windows 7' TEST_BROWSER_VERSION=10 - - TEST_BROWSER_NAME='internet explorer' TEST_BROWSER_OS='Windows 8.1' TEST_BROWSER_VERSION=11 - - TEST_BROWSER_NAME=safari TEST_BROWSER_OS='OS X 10.8' TEST_BROWSER_VERSION=6 - - TEST_BROWSER_NAME=safari TEST_BROWSER_OS='OS X 10.9' TEST_BROWSER_VERSION=7 + - TEST_BROWSER_NAME=chrome TEST_BROWSER_OS='Windows 10,Linux,OS X 10.11' + - TEST_BROWSER_NAME=firefox TEST_BROWSER_OS='Windows 10,Linux,OS X 10.11' + - TEST_BROWSER_NAME='internet explorer' TEST_BROWSER_OS='Windows 10' + - TEST_BROWSER_NAME=safari TEST_BROWSER_OS='OS X 10.11' global: - secure: QE5GqGd2hrpQsIgd8dlv3oRUUHqZayomzzQjNXOB81VQi241uz/ru+3GtBZLB5WLZCq/Gj89vbLnR0LN4ixlmPaWv3/WJQGyDGuRD/vMnccVl+rBUP/Hh2zdYwiISIGcrywNAE+KLus/lyt/ahVgzbaRaDSzrM1HaZFT/rndGck= - secure: g75sdctEwj0hoLW0Y08Tdv8s5scNzplB6a9EtaJ2vJD9S/bK+AsPqbWesGv1UlrFPCWdbV7Vg61vkmoUjcmb5xhqFIjcM9TlYJoKWeOTsOmnQoSIkIq6gMF1k02+LmKInbPgIzrp3m3jluS1qaOs/EzFpDnJp9hWBiAfXa12Jxk= From 6ec3af22ca952c5e7a5240da39d178fd995dfd5a Mon Sep 17 00:00:00 2001 From: Pierre Ossman Date: Tue, 29 Nov 2016 16:06:20 +0100 Subject: [PATCH 2/2] Skip language tests on broken browsers The hacks needed to run these tests require proper handling of properties. Unfortunately IE and old versions of Chrome mess up, so just skip the tests there. --- tests/test.util.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/test.util.js b/tests/test.util.js index bce475da..60cdb582 100644 --- a/tests/test.util.js +++ b/tests/test.util.js @@ -63,7 +63,19 @@ describe('Utils', function() { // environments, so we need to redefine it whilst running these // tests. origNavigator = Object.getOwnPropertyDescriptor(window, "navigator"); + if (origNavigator === undefined) { + // Object.getOwnPropertyDescriptor() doesn't work + // properly in any version of IE + this.skip(); + } + Object.defineProperty(window, "navigator", {value: {}}); + if (window.navigator.languages !== undefined) { + // Object.defineProperty() doesn't work properly in old + // versions of Chrome + this.skip(); + } + window.navigator.languages = []; }); afterEach(function () {