From abfe5b7a37414bdd073152f55018fd3995aac50d Mon Sep 17 00:00:00 2001
From: Samuel Mannehed <samuel@cendio.se>
Date: Mon, 16 Oct 2017 15:39:10 +0200
Subject: [PATCH] Wait for challenge before asking for password

Fixes #928.
---
 core/rfb.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/rfb.js b/core/rfb.js
index a4b5417e..a33d767b 100644
--- a/core/rfb.js
+++ b/core/rfb.js
@@ -836,13 +836,13 @@ RFB.prototype = {
     },
 
     _negotiate_std_vnc_auth: function () {
+        if (this._sock.rQwait("auth challenge", 16)) { return false; }
+
         if (this._rfb_password.length === 0) {
             this._onPasswordRequired(this);
             return false;
         }
 
-        if (this._sock.rQwait("auth challenge", 16)) { return false; }
-
         // TODO(directxman12): make genDES not require an Array
         var challenge = Array.prototype.slice.call(this._sock.rQshiftBytes(16));
         var response = RFB.genDES(this._rfb_password, challenge);