From a342ed703f0bd797e9b9f2ce01c43ec07ad88f29 Mon Sep 17 00:00:00 2001
From: Samuel Mannehed <samuel@cendio.se>
Date: Tue, 17 Oct 2017 12:16:38 +0200
Subject: [PATCH] Check if <audio>.play() returns a promise

It doesn't always. IE and Edge crashed when trying to play the bell due
to this. Fixes #929.
---
 app/ui.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/app/ui.js b/app/ui.js
index 5c073efc..f7cfc640 100644
--- a/app/ui.js
+++ b/app/ui.js
@@ -1714,8 +1714,10 @@ var UI = {
 
     bell: function(rfb) {
         if (WebUtil.getConfigVar('bell', 'on') === 'on') {
-            document.getElementById('noVNC_bell').play()
-                .catch(function(e) {
+            var promise = document.getElementById('noVNC_bell').play();
+            // The standards disagree on the return value here
+            if (promise) {
+                promise.catch(function(e) {
                     if (e.name === "NotAllowedError") {
                         // Ignore when the browser doesn't let us play audio.
                         // It is common that the browsers require audio to be
@@ -1724,6 +1726,7 @@ var UI = {
                         Log.Error("Unable to play bell: " + e);
                     }
                 });
+            }
         }
     },