From 8ad8f15cf6ea3a5417ee471d168a585f11f225bc Mon Sep 17 00:00:00 2001 From: Andrew Webster Date: Thu, 1 Feb 2018 11:46:38 -0500 Subject: [PATCH] Move writeSetting from updateSetting to initSetting initSetting was the only place that supplied a 'value' to updateSetting. So move it to clean up updateSetting. --- app/ui.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/app/ui.js b/app/ui.js index 7c754cec..592dfcf7 100644 --- a/app/ui.js +++ b/app/ui.js @@ -721,21 +721,17 @@ var UI = { if (val === null) { val = WebUtil.readSetting(name, defVal); } - UI.updateSetting(name, val); + WebUtil.setSetting(name, val); + UI.updateSetting(name); return val; }, // Update cookie and form control setting. If value is not set, then // updates from control to current cookie setting. - updateSetting: function(name, value) { - - // Save the cookie for this session - if (typeof value !== 'undefined') { - WebUtil.setSetting(name, value); - } + updateSetting: function(name) { // Update the settings control - value = UI.getSetting(name); + var value = UI.getSetting(name); var ctrl = document.getElementById('noVNC_setting_' + name); if (ctrl.type === 'checkbox') {