diff --git a/app/ui.js b/app/ui.js index 327722ec..1909dee2 100644 --- a/app/ui.js +++ b/app/ui.js @@ -1020,7 +1020,6 @@ const UI = { UI.rfb = new RFB(document.getElementById('noVNC_container'), url, { shared: UI.getSetting('shared'), - showDotCursor: UI.getSetting('show_dot'), repeaterID: UI.getSetting('repeaterID'), credentials: { password: password } }); UI.rfb.addEventListener("connect", UI.connectFinished); @@ -1034,6 +1033,7 @@ const UI = { UI.rfb.clipViewport = UI.getSetting('view_clip'); UI.rfb.scaleViewport = UI.getSetting('resize') === 'scale'; UI.rfb.resizeSession = UI.getSetting('resize') === 'remote'; + UI.rfb.showDotCursor = UI.getSetting('show_dot'); UI.updateViewOnly(); // requires UI.rfb }, diff --git a/core/rfb.js b/core/rfb.js index 3d45da4f..f01d38f2 100644 --- a/core/rfb.js +++ b/core/rfb.js @@ -52,7 +52,6 @@ export default class RFB extends EventTargetMixin { this._rfb_credentials = options.credentials || {}; this._shared = 'shared' in options ? !!options.shared : true; this._repeaterID = options.repeaterID || ''; - this._showDotCursor = options.showDotCursor || false; this._wsProtocols = options.wsProtocols || []; // Internal state @@ -247,6 +246,12 @@ export default class RFB extends EventTargetMixin { this._clipViewport = false; this._scaleViewport = false; this._resizeSession = false; + + this._showDotCursor = false; + if (options.showDotCursor !== undefined) { + Log.Warn("Specifying showDotCursor as a RFB constructor argument is deprecated"); + this._showDotCursor = options.showDotCursor; + } } // ===== PROPERTIES ===== diff --git a/docs/API.md b/docs/API.md index 05c61223..aa6337fe 100644 --- a/docs/API.md +++ b/docs/API.md @@ -187,11 +187,6 @@ connection to a specified VNC server. - A `DOMString` specifying the ID to provide to any VNC repeater encountered. - `showDotCursor` - - A `boolean` indicating whether a dot cursor should be shown - instead of a zero-sized or fully-transparent cursor if the - server sets such invisible cursor. Disabled by default. - `wsProtocols` - An `Array` of `DOMString`s specifying the sub-protocols to use in the WebSocket connection. Empty by default.