jcarr
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handle quick Cursor detach after mouse up 

This timer might fire after the Cursor object has detached from a DOM
element, causing crashes. This will likely not happen in real scenarios,
but the tests are quick enough to trigger this.
This commit is contained in:
Pierre Ossman 2020-06-25 14:37:21 +02:00
parent 6c6776a7a0
commit 484a9551d1
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/util/cursor.js
View File

@ -179,6 +179,10 @@ export default class Cursor {
// should be visible. // should be visible.
if (this._captureIsActive()) { if (this._captureIsActive()) {
window.setTimeout(() => { window.setTimeout(() => {
// We might have detached at this point
if (!this._target) {
return;
}
// Refresh the target from elementFromPoint since queued events // Refresh the target from elementFromPoint since queued events
// might have altered the DOM // might have altered the DOM
target = document.elementFromPoint(event.clientX, target = document.elementFromPoint(event.clientX,