From 464944844f039eea05fa19b0d1747d7ac28c4ac3 Mon Sep 17 00:00:00 2001 From: Solly Ross Date: Wed, 6 Jan 2016 11:18:47 -0500 Subject: [PATCH] Remove unused variables in the TIGHT server init This commit removes some unused variables in the TIGHT server init section of the server init handler, replacing them with documenting comments and calls to rQskipBytes. Fixes #440. --- include/rfb.js | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/include/rfb.js b/include/rfb.js index 0aa320d3..5d98dbd2 100644 --- a/include/rfb.js +++ b/include/rfb.js @@ -920,18 +920,17 @@ var RFB; var totalMessagesLength = (numServerMessages + numClientMessages + numEncodings) * 16; if (this._sock.rQwait('TightVNC extended server init header', totalMessagesLength, 32 + name_length)) { return false; } - var i; - for (i = 0; i < numServerMessages; i++) { - var srvMsg = this._sock.rQshiftStr(16); - } + // we don't actually do anything with the capability information that TIGHT sends, + // so we just skip the all of this. - for (i = 0; i < numClientMessages; i++) { - var clientMsg = this._sock.rQshiftStr(16); - } + // TIGHT server message capabilities + this._sock.rQskipBytes(16 * numServerMessages); - for (i = 0; i < numEncodings; i++) { - var encoding = this._sock.rQshiftStr(16); - } + // TIGHT client message capabilities + this._sock.rQskipBytes(16 * numClientMessages); + + // TIGHT encoding capabilities + this._sock.rQskipBytes(16 * numEncodings); } // NB(directxman12): these are down here so that we don't run them multiple times