From 41ddb35458f2b64d1aaa2d262c7130e069ea2d99 Mon Sep 17 00:00:00 2001 From: Juanjo Diaz Date: Wed, 27 Feb 2019 10:14:50 +0200 Subject: [PATCH] Replace unnecessary function supportsCursorURIs by a constant variable --- core/util/browser.js | 32 +++++++++++++------------------- core/util/cursor.js | 2 +- 2 files changed, 14 insertions(+), 20 deletions(-) diff --git a/core/util/browser.js b/core/util/browser.js index 78e104de..8996cfed 100644 --- a/core/util/browser.js +++ b/core/util/browser.js @@ -25,30 +25,24 @@ window.addEventListener('touchstart', function onFirstTouch() { // brings us a bit closer but is not optimal. export let dragThreshold = 10 * (window.devicePixelRatio || 1); -let _cursor_uris_supported = null; +let _supportsCursorURIs = false; -export function supportsCursorURIs() { - if (_cursor_uris_supported === null) { - try { - const target = document.createElement('canvas'); - target.style.cursor = 'url("data:image/x-icon;base64,AAACAAEACAgAAAIAAgA4AQAAFgAAACgAAAAIAAAAEAAAAAEAIAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAD/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////AAAAAAAAAAAAAAAAAAAAAA==") 2 2, default'; +try { + const target = document.createElement('canvas'); + target.style.cursor = 'url("data:image/x-icon;base64,AAACAAEACAgAAAIAAgA4AQAAFgAAACgAAAAIAAAAEAAAAAEAIAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAD/////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////AAAAAAAAAAAAAAAAAAAAAA==") 2 2, default'; - if (target.style.cursor) { - Log.Info("Data URI scheme cursor supported"); - _cursor_uris_supported = true; - } else { - Log.Warn("Data URI scheme cursor not supported"); - _cursor_uris_supported = false; - } - } catch (exc) { - Log.Error("Data URI scheme cursor test exception: " + exc); - _cursor_uris_supported = false; - } + if (target.style.cursor) { + Log.Info("Data URI scheme cursor supported"); + _supportsCursorURIs = true; + } else { + Log.Warn("Data URI scheme cursor not supported"); } - - return _cursor_uris_supported; +} catch (exc) { + Log.Error("Data URI scheme cursor test exception: " + exc); } +export const supportsCursorURIs = _supportsCursorURIs; + let _supportsImageMetadata = false; try { new ImageData(new Uint8ClampedArray(4), 1, 1); diff --git a/core/util/cursor.js b/core/util/cursor.js index b73f862b..0d0b754a 100644 --- a/core/util/cursor.js +++ b/core/util/cursor.js @@ -6,7 +6,7 @@ import { supportsCursorURIs, isTouchDevice } from './browser.js'; -const useFallback = !supportsCursorURIs() || isTouchDevice; +const useFallback = !supportsCursorURIs || isTouchDevice; export default class Cursor { constructor() {