From 3b4fd003c2ba6e0294282ea203e6ead6e9275317 Mon Sep 17 00:00:00 2001 From: Solly Ross Date: Fri, 19 Sep 2014 15:14:34 -0400 Subject: [PATCH] Fixed broken mouse test in test.rfb.js Because we use the XOR (`^`) operator, the button mask must be set before a MouseUp event happens, otherwise we'll send a pointer event like it was a MouseDown event. The button mask was not set in one of the tests, so the test was failing. --- tests/test.rfb.js | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test.rfb.js b/tests/test.rfb.js index 64625870..fb32af0f 100644 --- a/tests/test.rfb.js +++ b/tests/test.rfb.js @@ -1520,6 +1520,7 @@ describe('Remote Frame Buffer Protocol Client', function() { }); it('should send a mask of 0 on mouseup', function () { + client._mouse_buttonMask = 0x001; client._mouse._onMouseButton(10, 12, 0, 0x001); expect(client._sock.send).to.have.been.calledOnce; var pointer_msg = RFB.messages.pointerEvent(10, 12, 0x000);