From 38d8cfdf835a297515aa4e2a19f11cb730018c55 Mon Sep 17 00:00:00 2001 From: Samuel Mannehed Date: Mon, 28 Nov 2016 10:02:13 +0100 Subject: [PATCH] Fix fallback error handling Start using the correct API for window.addEventListener('error',..). Unlike when using onerror, the handler function gets an event. --- app/ui.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/ui.js b/app/ui.js index 4bd5f0fb..9d0a3ba3 100644 --- a/app/ui.js +++ b/app/ui.js @@ -26,12 +26,16 @@ var UI; "use strict"; // Fallback for all uncought errors - window.addEventListener('error', function(msg, url, line) { + window.addEventListener('error', function(e) { try { + var file = e.filename; + var line = e.lineno; + var col = e.colno; + var msg = e.error.message; document.getElementById('noVNC_fallback_error') .classList.add("noVNC_open"); document.getElementById('noVNC_fallback_errormsg').innerHTML = - url + ' (' + line + ')

' + msg; + msg + '

' + 'at: ' + file + ':' + line + ':' + col; } catch (exc) { document.write("noVNC encountered an error."); }