From 270bdbd7fbf3ce24893fa81f22cdfb3d68e91c49 Mon Sep 17 00:00:00 2001 From: Samuel Mannehed Date: Wed, 5 Apr 2017 14:00:59 +0200 Subject: [PATCH] Always send mouseUp events properly If down is false we can't just toggle the current internal state, even though this is correct most of the time. There are cases where we don't get the down event and thus won't have a correct internal state. For example, when clicking in the session after using the clipboard textarea. If down is false, we always want to send a mouse event with the button in 'up'-state. --- core/rfb.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/rfb.js b/core/rfb.js index f40c7d78..b60a1198 100644 --- a/core/rfb.js +++ b/core/rfb.js @@ -669,7 +669,7 @@ RFB.prototype = { if (down) { this._mouse_buttonMask |= bmask; } else { - this._mouse_buttonMask ^= bmask; + this._mouse_buttonMask &= ~bmask; } if (this._viewportDrag) {