jcarr
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow longer passwords in Plain authentication 

Some people have longer passwords than 256 characters (hooray for
password managers!). Server implementations also allow longer passwords:
TigerVNC allows up to 1024 characters.
This commit is contained in:
lhchavez 2021-03-03 17:34:02 -08:00
parent 5a0cceb815
commit 18593154d3
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
core/rfb.js
View File

@ -1438,9 +1438,18 @@ export default class RFB extends EventTargetMixin {
const user = encodeUTF8(this._rfbCredentials.username); const user = encodeUTF8(this._rfbCredentials.username);
const pass = encodeUTF8(this._rfbCredentials.password); const pass = encodeUTF8(this._rfbCredentials.password);
// XXX we assume lengths are <= 255 (should not be an issue in the real world) this._sock.send([
this._sock.send([0, 0, 0, user.length]); (user.length >> 24) & 0xFF,
this._sock.send([0, 0, 0, pass.length]); (user.length >> 16) & 0xFF,
(user.legnth >> 8) & 0xFF,
user.length & 0xFF
]);
this._sock.send([
(pass.length >> 24) & 0xFF,
(pass.length >> 16) & 0xFF,
(pass.legnth >> 8) & 0xFF,
pass.length & 0xFF
]);
this._sock.sendString(user); this._sock.sendString(user);
this._sock.sendString(pass); this._sock.sendString(pass);