jcarr
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Stop send mouse clicks while dragging in view only

This commit is contained in:
Samuel Mannehed 2020-05-10 02:05:38 +02:00
parent 006743857b
commit 11a22dbf0c
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/rfb.js
View File

@ -836,6 +836,8 @@ export default class RFB extends EventTargetMixin {
return;
}
if (this._viewOnly) { return; }
// Otherwise we treat this as a mouse click event.
// Send the button down event here, as the button up
// event is sent at the end of this function.

7
tests/test.rfb.js
View File

@ -514,6 +514,13 @@ describe('Remote Frame Buffer Protocol Client', function () {
expect(RFB.messages.pointerEvent).to.have.been.calledTwice;
});
it('should not send button messages when in view only', function () {
client._viewOnly = true;
client._handleMouseButton(13, 9, 0x001);
client._handleMouseButton(13, 9, 0x000);
expect(RFB.messages.pointerEvent).to.not.have.been.called;
});
it('should send button message directly when drag is disabled', function () {
client.dragViewport = false;
client._handleMouseButton(13, 9, 0x001);