jcarr
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Race Condition in Display#clear on IE10 

There was a race condition in Display#clear on IE10
because we resize and then clear that causes the canvas
to not actually end up cleared.  Clearing the current
viewport first solves the issue.  It doesn't appear to
affect other platforms, so it's inside a engine check
(`Util.Engine.trident === 6`).  Once we stop supporting
IE10, we should just remove this, because it's not the best
to have Engine-specific code.
This commit is contained in:
Solly Ross 2014-09-22 21:37:04 -04:00
parent 3b4fd003c2
commit 0b0b0433b5
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/display.js
View File

@ -312,6 +312,12 @@ var Display;
this.resize(this._logo.width, this._logo.height); this.resize(this._logo.width, this._logo.height);
this.blitStringImage(this._logo.data, 0, 0); this.blitStringImage(this._logo.data, 0, 0);
} else { } else {
if (Util.Engine.trident === 6) {
// NB(directxman12): there's a bug in IE10 where we can fail to actually
// clear the canvas here because of the resize.
// Clearing the current viewport first fixes the issue
this._drawCtx.clearRect(0, 0, this._viewportLoc.w, this._viewportLoc.h);
}
this.resize(640, 20); this.resize(640, 20);
this._drawCtx.clearRect(0, 0, this._viewportLoc.w, this._viewportLoc.h); this._drawCtx.clearRect(0, 0, this._viewportLoc.w, this._viewportLoc.h);
} }