jcarr
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix panning test for high DPI devices 

There is a drag-threshold in the panning code which the tests didn't
account for. This caused the tests to fail when window.devicePixelRatio
was higher than 1.
This commit is contained in:
Samuel Mannehed 2017-04-21 15:23:18 +02:00
parent e4290d8c00
commit 0613d18894
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/test.rfb.js
View File

@ -1988,19 +1988,24 @@ describe('Remote Frame Buffer Protocol Client', function() {
}); });
it('if enabled, viewportDragging should occur on mouse movement while a button is down', function () { it('if enabled, viewportDragging should occur on mouse movement while a button is down', function () {
var oldX = 123;
var oldY = 109;
var newX = 123 + 11 * window.devicePixelRatio;
var newY = 109 + 4 * window.devicePixelRatio;
client._viewportDrag = true; client._viewportDrag = true;
client._viewportDragging = true; client._viewportDragging = true;
client._viewportHasMoved = false; client._viewportHasMoved = false;
client._viewportDragPos = { x: 23, y: 9 }; client._viewportDragPos = { x: oldX, y: oldY };
client._display.viewportChangePos = sinon.spy(); client._display.viewportChangePos = sinon.spy();
client._mouse._onMouseMove(10, 4); client._mouse._onMouseMove(newX, newY);
expect(client._viewportDragging).to.be.true; expect(client._viewportDragging).to.be.true;
expect(client._viewportHasMoved).to.be.true; expect(client._viewportHasMoved).to.be.true;
expect(client._viewportDragPos).to.deep.equal({ x: 10, y: 4 }); expect(client._viewportDragPos).to.deep.equal({ x: newX, y: newY });
expect(client._display.viewportChangePos).to.have.been.calledOnce; expect(client._display.viewportChangePos).to.have.been.calledOnce;
expect(client._display.viewportChangePos).to.have.been.calledWith(13, 5); expect(client._display.viewportChangePos).to.have.been.calledWith(oldX - newX, oldY - newY);
}); });
}); });