jcarr
/
noVNC
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow connecting with empty string credentials 

Checking for undefined instead of falsy. That way an empty strings are allowed.
This commit is contained in:
Chris J 2019-11-07 15:15:15 -05:00 committed by Samuel Mannehed
parent c15502525e
commit 01d4514dee
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/rfb.js
View File

@ -940,9 +940,9 @@ export default class RFB extends EventTargetMixin {
// authentication // authentication
_negotiate_xvp_auth() { _negotiate_xvp_auth() {
if (!this._rfb_credentials.username || if (this._rfb_credentials.username === undefined ||
!this._rfb_credentials.password || this._rfb_credentials.password === undefined ||
!this._rfb_credentials.target) { this._rfb_credentials.target === undefined) {
this.dispatchEvent(new CustomEvent( this.dispatchEvent(new CustomEvent(
"credentialsrequired", "credentialsrequired",
{ detail: { types: ["username", "password", "target"] } })); { detail: { types: ["username", "password", "target"] } }));
@ -961,7 +961,7 @@ export default class RFB extends EventTargetMixin {
_negotiate_std_vnc_auth() { _negotiate_std_vnc_auth() {
if (this._sock.rQwait("auth challenge", 16)) { return false; } if (this._sock.rQwait("auth challenge", 16)) { return false; }
if (!this._rfb_credentials.password) { if (this._rfb_credentials.password === undefined) {
this.dispatchEvent(new CustomEvent( this.dispatchEvent(new CustomEvent(
"credentialsrequired", "credentialsrequired",
{ detail: { types: ["password"] } })); { detail: { types: ["password"] } }));