jcarr
/
libnotify
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

notify-send: Support commas in icon filenames 

Do not cut off an icon filename (passed to -i) at the first comma
character. The original motivation probably was to support a list of
icon names in -i separated by comma. However, this has never been
implemented and the help text for -i also only mentions "an icon".

Hence, no functionality is lost by this change. In contrast, -i now
supports commas in icon filepaths.

https://gitlab.gnome.org/GNOME/libnotify/-/issues/16
This commit is contained in:
Thorsten Wißmann 2020-12-07 20:22:15 +01:00
parent 48e64c39bc
commit dfaa76109e
2 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/notify-send.xml
View File

@ -73,7 +73,7 @@
</listitem>
</varlistentry>
<varlistentry>
<term><option>-i</option>, <option>--icon</option>=<replaceable>ICON</replaceable>[,<replaceable>ICON</replaceable>…]
<term><option>-i</option>, <option>--icon</option>=<replaceable>ICON</replaceable>
</term>
<listitem>
<para>Specifies an icon filename or stock icon to display.</para>

15
tools/notify-send.c
View File

@ -128,7 +128,6 @@ main (int argc, char *argv[])
static const char *type = NULL;
static char *app_name = NULL;
static char *icon_str = NULL;
static char *icons = NULL;
static char **n_text = NULL;
static char **hints = NULL;
static gboolean do_version = FALSE;
@ -150,9 +149,9 @@ main (int argc, char *argv[])
"notification."), N_("TIME")},
{"app-name", 'a', 0, G_OPTION_ARG_STRING, &app_name,
N_("Specifies the app name for the icon"), N_("APP_NAME")},
{"icon", 'i', 0, G_OPTION_ARG_FILENAME, &icons,
{"icon", 'i', 0, G_OPTION_ARG_FILENAME, &icon_str,
N_("Specifies an icon filename or stock icon to display."),
N_("ICON[,ICON...]")},
N_("ICON")},
{"category", 'c', 0, G_OPTION_ARG_FILENAME, &type,
N_("Specifies the notification category."),
N_("TYPE[,TYPE...]")},
@ -215,16 +214,6 @@ main (int argc, char *argv[])
}
}
if (icons != NULL) {
char *c;
/* XXX */
if ((c = strchr (icons, ',')) != NULL)
*c = '\0';
icon_str = icons;
}
if (!notify_init ("notify-send"))
exit (1);