jcarr
/
libnotify
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

notify-send: allow passing colon as hint value 

While some hints like image-path or sound-file supports parameters using the
file:// protocol, it's impossible to pass such hints to notify-send, because
it splits the passed argument so that it can have an unlimited number of colons,
while only 3 should be there (as per TYPE:NAME:VALUE format).

So, make `g_strsplit` to accept only 3 tokens as maximum, while pass the
remaining parameters all-together.

So now it's possible to do
  notify-send -h string:image-path:file:///usr/share/icons/foo.png
This commit is contained in:
Marco Trevisan (Treviño) 2018-11-09 01:45:54 -06:00 committed by Iain Lane
parent 3f71a3b3ba
commit 9862ab85e8
No known key found for this signature in database
GPG Key ID: E352D5C51C5041D4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/notify-send.c
View File

@ -246,7 +246,7 @@ main (int argc, char *argv[])
char **tokens = NULL; char **tokens = NULL;
while ((hint = hints[i++])) { while ((hint = hints[i++])) {
tokens = g_strsplit (hint, ":", -1); tokens = g_strsplit (hint, ":", 3);
l = g_strv_length (tokens); l = g_strv_length (tokens);
if (l != 3) { if (l != 3) {