Compare commits

...

2 Commits

Author SHA1 Message Date
Jeff Carr 6a205dfa4e wasn't compiling on the mac 2025-08-31 12:17:05 -05:00
Castor Regex df3dbcbc7e fix(hostname): correct usage of exec.Command for darwin build 2025-08-31 11:32:11 -05:00
3 changed files with 13 additions and 2 deletions

View File

@ -1,3 +1,6 @@
Get() the full hostname for the OS.
* only cares about the hostname in DNS
* I wrote this before or not being aware of os.Hostname()
probably this package should go away

8
get.go
View File

@ -1,9 +1,17 @@
package hostname
import "fmt"
// returns the hostname
// hostname is always set to the best effort
// error is set if hostname isn't real
func Get() (string, error) {
hostname, err := osGetHostname()
if hostname == "" {
if err == nil {
err = fmt.Errorf("your machines' hostname is not set")
}
hostname = "unconfigured.hostname"
}
return hostname, err
}

View File

@ -12,12 +12,12 @@ import (
// scutil --set HostName my-mac.example.com
func osGetHostname() (string, error) {
return scutil([]string{"-get", "HostName"})
return scutil([]string{"--get", "HostName"})
}
// getDomainName executes the 'domainname' command and returns its output.
func scutil(args []string) (string, error) {
cmd := exec.Command("scutil", args)
cmd := exec.Command("scutil", args...)
var out bytes.Buffer
cmd.Stdout = &out
if err := cmd.Run(); err != nil {