From f408a756f96bda643d143129f400cd98492864ba Mon Sep 17 00:00:00 2001 From: Jeff Carr Date: Wed, 14 Feb 2024 01:26:31 -0600 Subject: [PATCH] actually fail on go mod tidy failures Signed-off-by: Jeff Carr --- doRelease.go | 7 ++++++- releaseWindow.go | 10 ++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/doRelease.go b/doRelease.go index 2ff444f..98687f3 100644 --- a/doRelease.go +++ b/doRelease.go @@ -109,7 +109,12 @@ func doRelease() bool { return false } release.current.status.CheckSafeGoSumRemake() - release.current.status.MakeRedomod() + if release.current.status.MakeRedomod() { + log.Info("Redo mod ok") + } else { + log.Info("go mod tidy not ok") + return false + } if ok, _ := release.current.status.CheckGoSum(); ok { log.Info("repo has go.sum requirements that are clean") // release.current.setGoSumStatus("CLEAN") diff --git a/releaseWindow.go b/releaseWindow.go index 9a93c3e..863178f 100644 --- a/releaseWindow.go +++ b/releaseWindow.go @@ -221,7 +221,10 @@ func createReleaseBox(box *gui.Node) { release.makeRedomodB = release.grid.NewButton("make redomod", func() { buttonDisable() - release.current.status.MakeRedomod() + if release.current.status.MakeRedomod() { + } else { + log.Info("This is bad. stop here") + } buttonEnable() }) @@ -256,7 +259,10 @@ func createReleaseBox(box *gui.Node) { func fullDoubleCheckFix() bool { release.current.status.CheckSafeGoSumRemake() - release.current.status.MakeRedomod() + if ! release.current.status.MakeRedomod() { + log.Info("go mod failed") + return false + } if ok, _ := release.current.status.CheckGoSum(); ok { log.Info("go.sum is clean") } else {