Merge c9c9785345
into d8f796af33
This commit is contained in:
commit
abd05577e9
|
@ -100,7 +100,7 @@ func handleMethods(cs *ConfigState, w io.Writer, v reflect.Value) (handled bool)
|
||||||
// Choose whether or not to do error and Stringer interface lookups against
|
// Choose whether or not to do error and Stringer interface lookups against
|
||||||
// the base type or a pointer to the base type depending on settings.
|
// the base type or a pointer to the base type depending on settings.
|
||||||
// Technically calling one of these methods with a pointer receiver can
|
// Technically calling one of these methods with a pointer receiver can
|
||||||
// mutate the value, however, types which choose to satisify an error or
|
// mutate the value, however, types which choose to satisfy an error or
|
||||||
// Stringer interface with a pointer receiver should not be mutating their
|
// Stringer interface with a pointer receiver should not be mutating their
|
||||||
// state inside these interface methods.
|
// state inside these interface methods.
|
||||||
if !cs.DisablePointerMethods && !UnsafeDisabled && !v.CanAddr() {
|
if !cs.DisablePointerMethods && !UnsafeDisabled && !v.CanAddr() {
|
||||||
|
|
|
@ -59,7 +59,7 @@ type ConfigState struct {
|
||||||
//
|
//
|
||||||
// NOTE: This might be an unsafe action since calling one of these methods
|
// NOTE: This might be an unsafe action since calling one of these methods
|
||||||
// with a pointer receiver could technically mutate the value, however,
|
// with a pointer receiver could technically mutate the value, however,
|
||||||
// in practice, types which choose to satisify an error or Stringer
|
// in practice, types which choose to satisfy an error or Stringer
|
||||||
// interface with a pointer receiver should not be mutating their state
|
// interface with a pointer receiver should not be mutating their state
|
||||||
// inside these interface methods. As a result, this option relies on
|
// inside these interface methods. As a result, this option relies on
|
||||||
// access to the unsafe package, so it will not have any effect when
|
// access to the unsafe package, so it will not have any effect when
|
||||||
|
|
Loading…
Reference in New Issue