Correct valuesSorter.Less function for uintptr.

The function sort be sorting the uintptr itself, not the address of it.
Also, the previous code could easily panic on an unaddressable
reflect.Value since it was trying to take an address.
This commit is contained in:
Dave Collins 2013-11-14 22:03:41 -06:00
parent 67c401cf12
commit 3b4a2055ce
1 changed files with 1 additions and 1 deletions

View File

@ -284,7 +284,7 @@ func (s *valuesSorter) Less(i, j int) bool {
case reflect.String:
return s.values[i].String() < s.values[j].String()
case reflect.Uintptr:
return s.values[i].UnsafeAddr() < s.values[j].UnsafeAddr()
return s.values[i].Uint() < s.values[j].Uint()
}
return s.values[i].String() < s.values[j].String()
}