Merge pull request #10 from daenney/parseint

Support different integer formats
This commit is contained in:
Alex Flint 2022-10-02 12:39:56 -07:00 committed by GitHub
commit e7a360897d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions

View File

@ -108,13 +108,13 @@ func ParseValue(v reflect.Value, s string) error {
} }
v.SetBool(x) v.SetBool(x)
case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64: case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
x, err := strconv.ParseInt(s, 10, v.Type().Bits()) x, err := strconv.ParseInt(s, 0, v.Type().Bits())
if err != nil { if err != nil {
return err return err
} }
v.SetInt(x) v.SetInt(x)
case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr: case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
x, err := strconv.ParseUint(s, 10, v.Type().Bits()) x, err := strconv.ParseUint(s, 0, v.Type().Bits())
if err != nil { if err != nil {
return err return err
} }

View File

@ -48,6 +48,7 @@ func TestParseValue(t *testing.T) {
// integers // integers
assertParse(t, int(123), "123") assertParse(t, int(123), "123")
assertParse(t, int(123), "1_2_3")
assertParse(t, int8(123), "123") assertParse(t, int8(123), "123")
assertParse(t, int16(123), "123") assertParse(t, int16(123), "123")
assertParse(t, int32(123), "123") assertParse(t, int32(123), "123")
@ -55,6 +56,7 @@ func TestParseValue(t *testing.T) {
// unsigned integers // unsigned integers
assertParse(t, uint(123), "123") assertParse(t, uint(123), "123")
assertParse(t, uint(123), "1_2_3")
assertParse(t, byte(123), "123") assertParse(t, byte(123), "123")
assertParse(t, uint8(123), "123") assertParse(t, uint8(123), "123")
assertParse(t, uint16(123), "123") assertParse(t, uint16(123), "123")