From b06e86edc27e2f138fa0e073d161bdb61df973dc Mon Sep 17 00:00:00 2001 From: Tero Marttila Date: Fri, 24 Jun 2022 12:21:11 +0300 Subject: [PATCH 1/2] github workflows: add go fmt, vet checks --- .github/workflow-scripts/check-gofmt.sh | 11 +++++++++++ .github/workflows/build.yml | 6 ++++++ 2 files changed, 17 insertions(+) create mode 100755 .github/workflow-scripts/check-gofmt.sh diff --git a/.github/workflow-scripts/check-gofmt.sh b/.github/workflow-scripts/check-gofmt.sh new file mode 100755 index 0000000..0a65b81 --- /dev/null +++ b/.github/workflow-scripts/check-gofmt.sh @@ -0,0 +1,11 @@ +#!/bin/sh + +set -ue + +fmt_list="$(gofmt -l "$@")" + +if [ -n "$fmt_list" ]; then + echo "Check gofmt failed: " >&2 + echo "${fmt_list}" | sed -e 's/^/\t/' >&2 + exit 1 +fi diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 86d6f70..c210ccc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -25,12 +25,18 @@ jobs: - name: Download dependencies run: go mod download + - name: Check gofmt + run: .github/workflow-scripts/check-gofmt.sh . + - name: Build run: go build -v - name: Test run: go test -v + - name: Vet + run: go vet + - name: Upload uses: actions/upload-artifact@v3 with: From c09c90d0a931888862262a6ed3753eed0af4ddca Mon Sep 17 00:00:00 2001 From: Tero Marttila Date: Fri, 24 Jun 2022 12:26:53 +0300 Subject: [PATCH 2/2] github actions: experiment with workflow error commands --- .github/workflow-scripts/check-gofmt.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflow-scripts/check-gofmt.sh b/.github/workflow-scripts/check-gofmt.sh index 0a65b81..4e5122a 100755 --- a/.github/workflow-scripts/check-gofmt.sh +++ b/.github/workflow-scripts/check-gofmt.sh @@ -6,6 +6,10 @@ fmt_list="$(gofmt -l "$@")" if [ -n "$fmt_list" ]; then echo "Check gofmt failed: " >&2 - echo "${fmt_list}" | sed -e 's/^/\t/' >&2 + + for file in "$fmt_list"; do + echo "::error file=${file},title=gofmt::gofmt check failed" + echo "\t$file" >&2 + done exit 1 fi