From 3adf184a4ad6f9012c8055b1af453394844898cd Mon Sep 17 00:00:00 2001 From: Jeff Carr Date: Wed, 8 Jan 2025 04:07:53 -0600 Subject: [PATCH] validate versions before running go get --- cleanGoSum.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/cleanGoSum.go b/cleanGoSum.go index ec4c981..85abac7 100644 --- a/cleanGoSum.go +++ b/cleanGoSum.go @@ -8,6 +8,7 @@ import ( "sort" "strings" + "go.wit.com/lib/protobuf/forgepb" "go.wit.com/lib/protobuf/gitpb" "go.wit.com/log" ) @@ -64,8 +65,11 @@ func cleanGoDepsCheckOk(check *gitpb.Repo) error { depRepo.GetVersion(), found.GetMasterVersion(), ends) errs := fmt.Sprintf("%s error %s vs %s %s", depRepo.GetGoPath(), depRepo.GetVersion(), found.GetMasterVersion(), ends) - cmd := []string{"go", "get", depRepo.GetGoPath() + "@" + found.GetMasterVersion()} - fixes = append(fixes, cmd) + if ok, _ := forgepb.ValidGoVersion(found.GetMasterVersion()); ok { + // can't go get invalid version numbers + cmd := []string{"go", "get", depRepo.GetGoPath() + "@" + found.GetMasterVersion()} + fixes = append(fixes, cmd) + } err = errors.New(errs) } }