jcarr
/
go-arg
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #120 from alexflint/dedent-tag-loop 

Move empty tag check inside loop
This commit is contained in:
Alex Flint 2020-07-06 09:59:15 -07:00 committed by GitHub
parent 2a3b5ea3cb 6be0398e80
commit a68c3d0653
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 62 additions and 61 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
parse.go
View File

@ -292,8 +292,10 @@ func cmdFromStruct(name string, dest path, t reflect.Type) (*command, error) {
// Look at the tag
var isSubcommand bool // tracks whether this field is a subcommand
if tag != "" {
for _, key := range strings.Split(tag, ",") {
if key == "" {
continue
}
key = strings.TrimLeft(key, " ")
var value string
if pos := strings.Index(key, ":"); pos != -1 {
@ -357,7 +359,6 @@ func cmdFromStruct(name string, dest path, t reflect.Type) (*command, error) {
return false
}
}
}
placeholder, hasPlaceholder := field.Tag.Lookup("placeholder")
if hasPlaceholder {