jcarr
/
go-arg
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drop unnecessary use of templates in this test

This commit is contained in:
Alex Flint 2022-10-29 12:28:06 -04:00
parent 23b2b67fe2
commit 197e226c77
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
parse_test.go
View File

@ -1458,18 +1458,18 @@ func TestMustParsePrintsVersion(t *testing.T) {
assert.Equal(t, "example 3.2.1\n", b.String()) assert.Equal(t, "example 3.2.1\n", b.String())
} }
type jsonMap struct { type mapWithUnmarshalText struct {
val map[string]string val map[string]string
} }
func (v *jsonMap) UnmarshalText(data []byte) error { func (v *mapWithUnmarshalText) UnmarshalText(data []byte) error {
return json.Unmarshal(data, &v.val) return json.Unmarshal(data, &v.val)
} }
func TestTextUnmarshallerEmpty(t *testing.T) { func TestTextUnmarshalerEmpty(t *testing.T) {
// based on https://github.com/alexflint/go-arg/issues/184 // based on https://github.com/alexflint/go-arg/issues/184
var args struct { var args struct {
Config jsonMap `arg:"--config"` Config mapWithUnmarshalText `arg:"--config"`
} }
err := parse("", &args) err := parse("", &args)
@ -1477,10 +1477,10 @@ func TestTextUnmarshallerEmpty(t *testing.T) {
assert.Empty(t, args.Config) assert.Empty(t, args.Config)
} }
func TestTextUnmarshallerEmptyPointer(t *testing.T) { func TestTextUnmarshalerEmptyPointer(t *testing.T) {
// a slight variant on https://github.com/alexflint/go-arg/issues/184 // a slight variant on https://github.com/alexflint/go-arg/issues/184
var args struct { var args struct {
Config *jsonMap `arg:"--config"` Config *mapWithUnmarshalText `arg:"--config"`
} }
err := parse("", &args) err := parse("", &args)
@ -1489,22 +1489,22 @@ func TestTextUnmarshallerEmptyPointer(t *testing.T) {
} }
// similar to the above but also implements MarshalText // similar to the above but also implements MarshalText
type jsonMap2[T any] struct { type mapWithMarshalText struct {
val T val map[string]string
} }
func (v *jsonMap2[T]) MarshalText(data []byte) error { func (v *mapWithMarshalText) MarshalText(data []byte) error {
return json.Unmarshal(data, &v.val) return json.Unmarshal(data, &v.val)
} }
func (v *jsonMap2[T]) UnmarshalText(data []byte) error { func (v *mapWithMarshalText) UnmarshalText(data []byte) error {
return json.Unmarshal(data, &v.val) return json.Unmarshal(data, &v.val)
} }
func TestTextMarshallerUnmarshallerEmpty(t *testing.T) { func TestTextMarshalerUnmarshalerEmpty(t *testing.T) {
// based on https://github.com/alexflint/go-arg/issues/184 // based on https://github.com/alexflint/go-arg/issues/184
var args struct { var args struct {
Config jsonMap2[map[string]string] `arg:"--config"` Config mapWithMarshalText `arg:"--config"`
} }
err := parse("", &args) err := parse("", &args)
@ -1512,10 +1512,10 @@ func TestTextMarshallerUnmarshallerEmpty(t *testing.T) {
assert.Empty(t, args.Config) assert.Empty(t, args.Config)
} }
func TestTextMarshallerUnmarshallerEmptyPointer(t *testing.T) { func TestTextMarshalerUnmarshalerEmptyPointer(t *testing.T) {
// a slight variant on https://github.com/alexflint/go-arg/issues/184 // a slight variant on https://github.com/alexflint/go-arg/issues/184
var args struct { var args struct {
Config *jsonMap2[map[string]string] `arg:"--config"` Config *mapWithMarshalText `arg:"--config"`
} }
err := parse("", &args) err := parse("", &args)