jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

libgit2 v1.5.0 #major #929

Merged
aryan9600 merged 2 commits from libgit2-v1.5.0 into main 2022-10-04 09:50:58 -05:00
Conversation 1 Commits 2 Files Changed 11 +2 -1
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 175b87e231 - Show all commits

2
README.md
View File

@ -12,7 +12,7 @@ Due to the fact that Go 1.11 module versions have semantic meaning and don't nec
|---------|---------------|
| main | (will be v35) |
| 1.5 | v34 |
| 1.3 | v34 |
| 1.3 | v33 |
| 1.2 | v32 |
| 1.1 | v31 |
| 1.0 | v30 |

1
transport.go
View File

@ -84,6 +84,7 @@ type Transport struct {
ptr *C.git_transport
}
// SmartRemoteConnectOptions gets a copy of the proxy options for this transport.
func (t *Transport) SmartRemoteConnectOptions() (*RemoteConnectOptions, error) {
runtime.LockOSThread()
defer runtime.UnlockOSThread()
lhchavez commented 2022-10-04 09:46:22 -05:00 (Migrated from github.com)
Review
Copy Link
// SmartRemoteConnectOptions gets a copy of the proxy options for this transport.
func (t *Transport) SmartRemoteConnectOptions() (*RemoteConnectOptions, error) {

let's keep the comment so that https://pkg.go.dev/github.com/libgit2/git2go/v34 shows more information to developers.

```suggestion // SmartRemoteConnectOptions gets a copy of the proxy options for this transport. func (t *Transport) SmartRemoteConnectOptions() (*RemoteConnectOptions, error) { ``` let's keep the comment so that https://pkg.go.dev/github.com/libgit2/git2go/v34 shows more information to developers.