jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Generate stringer files automatically #841

Merged
g4s8 merged 6 commits from 543-stringer-generate into main 2021-11-08 08:38:55 -06:00
Conversation 2 Commits 6 Files Changed 3 +4
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0cbbc1dc99 - Show all commits

4
.github/workflows/ci.yml vendored
View File

@ -117,6 +117,10 @@ jobs:
id: go id: go
- name: Check out code into the Go module directory - name: Check out code into the Go module directory
uses: actions/checkout@v2 uses: actions/checkout@v2
- name: Install libgit2 build dependencies
run: |
git submodule update --init
sudo apt-get install -y --no-install-recommends libssh2-1-dev
lhchavez commented 2021-11-08 08:27:42 -06:00 (Migrated from github.com)
Review
Copy Link
        sudo apt-get install -y --no-install-recommends libssh2-1-dev
        go install golang.org/x/tools/cmd/stringer@latest

haha, stringer wasn't installed! (and we may need to tweak PATH unless GH does it for us)

```suggestion sudo apt-get install -y --no-install-recommends libssh2-1-dev go install golang.org/x/tools/cmd/stringer@latest ``` haha, `stringer` wasn't installed! (and we may need to tweak `PATH` unless GH does it for us)
- name: Generate files - name: Generate files
run: make generate run: make generate
lhchavez commented 2021-11-08 07:55:26 -06:00 (Migrated from github.com)
Review
Copy Link
    - name: Install libgit2 build dependencies
      run: |
        git submodule update --init
        sudo apt-get install -y --no-install-recommends libssh2-1-dev
    - name: Generate files

oops, forgot this last round! otherwise make generate will fail because CGo won't be able to find git2.h: https://github.com/libgit2/git2go/runs/4139740720?check_suite_focus=true (note that this depends on the suggestion that was left in Makefile to work correctly).

```suggestion - name: Install libgit2 build dependencies run: | git submodule update --init sudo apt-get install -y --no-install-recommends libssh2-1-dev - name: Generate files ``` oops, forgot this last round! otherwise `make generate` will fail because CGo won't be able to find `git2.h`: https://github.com/libgit2/git2go/runs/4139740720?check_suite_focus=true (note that this depends on the suggestion that was left in `Makefile` to work correctly).
- name: Check nothing changed - name: Check nothing changed