Oid revamp #68

Merged
carlosmn merged 5 commits from cmn/oid-revamp into master 2014-03-19 01:20:45 -05:00
2 changed files with 4 additions and 4 deletions
Showing only changes of commit c9c7c1e779 - Show all commits

4
git.go
View File

@ -41,7 +41,7 @@ func newOidFromC(coid *C.git_oid) *Oid {
return oid return oid
} }
func NewOid(b []byte) *Oid { func NewOidFromBytes(b []byte) *Oid {
oid := new(Oid) oid := new(Oid)
copy(oid[0:20], b[0:20]) copy(oid[0:20], b[0:20])
return oid return oid
@ -51,7 +51,7 @@ func (oid *Oid) toC() *C.git_oid {
return (*C.git_oid)(unsafe.Pointer(oid)) return (*C.git_oid)(unsafe.Pointer(oid))
} }
func NewOidFromString(s string) (*Oid, error) { func NewOid(s string) (*Oid, error) {
o := new(Oid) o := new(Oid)
cs := C.CString(s) cs := C.CString(s)
defer C.free(unsafe.Pointer(cs)) defer C.free(unsafe.Pointer(cs))

View File

@ -27,7 +27,7 @@ func TestOdbStream(t *testing.T) {
error = stream.Close() error = stream.Close()
checkFatal(t, error) checkFatal(t, error)
expectedId, error := NewOidFromString("30f51a3fba5274d53522d0f19748456974647b4f") expectedId, error := NewOid("30f51a3fba5274d53522d0f19748456974647b4f")
checkFatal(t, error) checkFatal(t, error)
if stream.Id.Cmp(expectedId) != 0 { if stream.Id.Cmp(expectedId) != 0 {
t.Fatal("Wrong data written") t.Fatal("Wrong data written")