jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Add support for creating signed commits and signing commits during a rebase #626

Merged
mbfr merged 25 commits from master into master 2020-08-18 11:25:31 -05:00
Conversation 1 Commits 25 Files Changed 8 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3ba68ac003 - Show all commits

1
commit.go
View File

@ -73,6 +73,7 @@ func (c *Commit) WithSignature(signature string, signatureField string) (*Oid, e
var csf *C.char = nil var csf *C.char = nil
if signatureField != "" { if signatureField != "" {
csf = C.CString(signatureField) csf = C.CString(signatureField)
defer C.free(unsafe.Pointer(csf))
lhchavez commented 2020-08-14 08:41:25 -05:00 (Migrated from github.com)
Review
Copy Link

since C.CString() makes a copy, this needs a defer C.free(unsafe.Pointer(csf)) to avoid a memory leak: https://blog.golang.org/cgo#TOC_2.

since `C.CString()` makes a copy, this needs a `defer C.free(unsafe.Pointer(csf))` to avoid a memory leak: https://blog.golang.org/cgo#TOC_2.
mbfr commented 2020-08-14 09:50:05 -05:00 (Migrated from github.com)
Review
Copy Link

Added

Added
} }
runtime.LockOSThread() runtime.LockOSThread()