Add support for mempack #448

Merged
lhchavez merged 4 commits from mempack into master 2019-01-15 13:46:55 -06:00
1 changed files with 1 additions and 0 deletions
Showing only changes of commit f4ea2a561d - Show all commits

View File

@ -34,6 +34,7 @@ func NewMempack(odb *Odb) (mempack *Mempack, err error) {
carlosmn commented 2019-01-07 15:12:49 -06:00 (Migrated from github.com)
Review

This still needs to actually free the mempack, not just unset the finalizer.

This still needs to actually free the mempack, not just unset the finalizer.
carlosmn commented 2019-01-07 15:12:49 -06:00 (Migrated from github.com)
Review

This still needs to actually free the mempack, not just unset the finalizer.

This still needs to actually free the mempack, not just unset the finalizer.
carlosmn commented 2019-01-07 15:13:26 -06:00 (Migrated from github.com)
Review

We only need to lock the thread if we're going to deal with errors.

We only need to lock the thread if we're going to deal with errors.
carlosmn commented 2019-01-07 15:13:26 -06:00 (Migrated from github.com)
Review

We only need to lock the thread if we're going to deal with errors.

We only need to lock the thread if we're going to deal with errors.
carlosmn commented 2019-01-07 15:15:35 -06:00 (Migrated from github.com)
Review

The free should happen inside Mempack.Free.

The free should happen inside `Mempack.Free`.
carlosmn commented 2019-01-07 15:15:35 -06:00 (Migrated from github.com)
Review

The free should happen inside Mempack.Free.

The free should happen inside `Mempack.Free`.
lhchavez commented 2019-01-07 20:46:07 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:07 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:23 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:23 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:29 -06:00 (Migrated from github.com)
Review

Removed.

Removed.
lhchavez commented 2019-01-07 20:46:29 -06:00 (Migrated from github.com)
Review

Removed.

Removed.
}
ret = C.git_odb_add_backend(odb.ptr, mempack.ptr, C.int(999))
runtime.KeepAlive(odb)
carlosmn commented 2019-01-07 15:12:49 -06:00 (Migrated from github.com)
Review

This still needs to actually free the mempack, not just unset the finalizer.

This still needs to actually free the mempack, not just unset the finalizer.
carlosmn commented 2019-01-07 15:13:26 -06:00 (Migrated from github.com)
Review

We only need to lock the thread if we're going to deal with errors.

We only need to lock the thread if we're going to deal with errors.
carlosmn commented 2019-01-07 15:15:35 -06:00 (Migrated from github.com)
Review

The free should happen inside Mempack.Free.

The free should happen inside `Mempack.Free`.
lhchavez commented 2019-01-07 20:46:07 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:23 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:29 -06:00 (Migrated from github.com)
Review

Removed.

Removed.
if ret < 0 {
// Since git_odb_add_alternate() takes ownership of the ODB backend, the
// only case in which we free the mempack's memory is if it fails to be

carlosmn commented 2019-01-07 15:12:49 -06:00 (Migrated from github.com)
Review

This still needs to actually free the mempack, not just unset the finalizer.

This still needs to actually free the mempack, not just unset the finalizer.
carlosmn commented 2019-01-07 15:12:49 -06:00 (Migrated from github.com)
Review

This still needs to actually free the mempack, not just unset the finalizer.

This still needs to actually free the mempack, not just unset the finalizer.
carlosmn commented 2019-01-07 15:13:26 -06:00 (Migrated from github.com)
Review

We only need to lock the thread if we're going to deal with errors.

We only need to lock the thread if we're going to deal with errors.
carlosmn commented 2019-01-07 15:13:26 -06:00 (Migrated from github.com)
Review

We only need to lock the thread if we're going to deal with errors.

We only need to lock the thread if we're going to deal with errors.
carlosmn commented 2019-01-07 15:15:35 -06:00 (Migrated from github.com)
Review

The free should happen inside Mempack.Free.

The free should happen inside `Mempack.Free`.
carlosmn commented 2019-01-07 15:15:35 -06:00 (Migrated from github.com)
Review

The free should happen inside Mempack.Free.

The free should happen inside `Mempack.Free`.
lhchavez commented 2019-01-07 20:46:07 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:07 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:23 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:23 -06:00 (Migrated from github.com)
Review

Removed

Removed
lhchavez commented 2019-01-07 20:46:29 -06:00 (Migrated from github.com)
Review

Removed.

Removed.
lhchavez commented 2019-01-07 20:46:29 -06:00 (Migrated from github.com)
Review

Removed.

Removed.