Rebase wrapper #332
|
@ -0,0 +1,152 @@
|
|||
|
||||
package git
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
/*
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
#include <git2.h>
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
*/
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
import "C"
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
import (
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
"errors"
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
"runtime"
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
"unsafe"
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// RebaseOperationType is the type of rebase operation
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
type RebaseOperationType uint
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
const (
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// RebaseOperationPick The given commit is to be cherry-picked. The client should commit the changes and continue if there are no conflicts.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
RebaseOperationPick RebaseOperationType = C.GIT_REBASE_OPERATION_PICK
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// RebaseOperationEdit The given commit is to be cherry-picked, but the client should stop to allow the user to edit the changes before committing them.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
RebaseOperationEdit RebaseOperationType = C.GIT_REBASE_OPERATION_EDIT
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// RebaseOperationSquash The given commit is to be squashed into the previous commit. The commit message will be merged with the previous message.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
RebaseOperationSquash RebaseOperationType = C.GIT_REBASE_OPERATION_SQUASH
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// RebaseOperationFixup No commit will be cherry-picked. The client should run the given command and (if successful) continue.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
RebaseOperationFixup RebaseOperationType = C.GIT_REBASE_OPERATION_FIXUP
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// RebaseOperationExec No commit will be cherry-picked. The client should run the given command and (if successful) continue.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
RebaseOperationExec RebaseOperationType = C.GIT_REBASE_OPERATION_EXEC
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// RebaseOperation describes a single instruction/operation to be performed during the rebase.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
type RebaseOperation struct {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
Type RebaseOperationType
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
ID *Oid
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
Exec string
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
func rebaseOperationFromC(c *C.git_rebase_operation) *RebaseOperation {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
operation := &RebaseOperation{}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
operation.Type = RebaseOperationType(c._type)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
operation.ID = newOidFromC(&c.id)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
operation.Exec = C.GoString(c.exec)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return operation
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// RebaseOptions are used to tell the rebase machinery how to operate
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
type RebaseOptions struct{}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// Rebase object wrapper for C pointer
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
type Rebase struct {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
ptr *C.git_rebase
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
//RebaseInit initializes a rebase operation to rebase the changes in branch relative to upstream onto another branch.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
func (r *Repository) RebaseInit(branch *AnnotatedCommit, upstream *AnnotatedCommit, onto *AnnotatedCommit, opts *RebaseOptions) (*Rebase, error) {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
runtime.LockOSThread()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
defer runtime.UnlockOSThread()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
//TODO : use real rebase_options
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if opts != nil {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return nil, errors.New("RebaseOptions Not implemented yet")
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if branch == nil {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
branch = &AnnotatedCommit{ptr: nil}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if upstream == nil {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
upstream = &AnnotatedCommit{ptr: nil}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if onto == nil {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
onto = &AnnotatedCommit{ptr: nil}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
var ptr *C.git_rebase
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
err := C.git_rebase_init(&ptr, r.ptr, branch.ptr, upstream.ptr, onto.ptr, nil)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if err < 0 {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return nil, MakeGitError(err)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return newRebaseFromC(ptr), nil
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// Next performs the next rebase operation and returns the information about it.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// If the operation is one that applies a patch (which is any operation except GIT_REBASE_OPERATION_EXEC)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// then the patch will be applied and the index and working directory will be updated with the changes.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// If there are conflicts, you will need to address those before committing the changes.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
func (rebase *Rebase) Next() (*RebaseOperation, error) {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
runtime.LockOSThread()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
defer runtime.UnlockOSThread()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
var ptr *C.git_rebase_operation
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
err := C.git_rebase_next(&ptr, rebase.ptr)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if err < 0 {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return nil, MakeGitError(err)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return rebaseOperationFromC(ptr), nil
|
||||
![]() This looks like it should have a much more generic name, since what it does is unrelated to note rewriting and it's simply mapping an empty string and This looks like it should have a much more generic name, since what it does is unrelated to note rewriting and it's simply mapping an empty string and `NULL`.
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() I understand your point. Renamed to mapEmptyStringToNull :p I understand your point. Renamed to mapEmptyStringToNull :p
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// Commit commits the current patch.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// You must have resolved any conflicts that were introduced during the patch application from the git_rebase_next invocation.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
func (rebase *Rebase) Commit(ID *Oid, author, committer *Signature, message string) error {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
runtime.LockOSThread()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
defer runtime.UnlockOSThread()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
authorSig, err := author.toC()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if err != nil {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return err
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
defer C.git_signature_free(authorSig)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
committerSig, err := committer.toC()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if err != nil {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return err
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
cmsg := C.CString(message)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
defer C.free(unsafe.Pointer(cmsg))
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
cerr := C.git_rebase_commit(ID.toC(), rebase.ptr, authorSig, committerSig, nil, cmsg)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if cerr < 0 {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return MakeGitError(cerr)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return nil
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
// Finish finishes a rebase that is currently in progress once all patches have been applied.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
func (rebase *Rebase) Finish() error {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
runtime.LockOSThread()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
defer runtime.UnlockOSThread()
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
err := C.git_rebase_finish(rebase.ptr, nil)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
if err < 0 {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return MakeGitError(err)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return nil
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
//Free frees the Rebase object and underlying git_rebase C pointer.
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
func (rebase *Rebase) Free() {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
runtime.SetFinalizer(rebase, nil)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
C.git_reference_free(rebase.ptr)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
func newRebaseFromC(ptr *C.git_rebase) *Rebase {
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
rebase := &Rebase{ptr: ptr}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
runtime.SetFinalizer(rebase, (*Rebase).Free)
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
return rebase
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
||||
}
|
||||
![]() This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
![]() We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
![]() Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
![]() This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
![]() There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
![]() There is no There is no `git_rebase_next` in git2go, we have `Next()`.
![]() Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
![]() The other public id fields are named The other public id fields are named `Id`.
![]() Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
![]() Done Done
![]() Done Done
![]() Done Done
![]() Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
![]() Done Done
![]() Done Done
|
|
@ -0,0 +1,167 @@
|
|||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
package git
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
import (
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
"testing"
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
"time"
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
func createBranch(repo *Repository, branch string) error {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
head, err := repo.Head()
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
commit, err := repo.LookupCommit(head.Target())
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
_, err = repo.CreateBranch(branch, commit, false)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
func signature() *Signature {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return &Signature{
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
Name: "Emile",
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
Email: "emile@emile.com",
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
When: time.Now(),
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
func commitSomething(repo *Repository, something string) (*Oid, error) {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
head, err := repo.Head()
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
headCommit, err := repo.LookupCommit(head.Target())
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
index, err := NewIndex()
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
defer index.Free()
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
blobOID, err := repo.CreateBlobFromBuffer([]byte("fou"))
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
entry := &IndexEntry{
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
Mode: FilemodeBlob,
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
Id: blobOID,
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
Path: something,
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err := index.Add(entry); err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
newTreeOID, err := index.WriteTreeTo(repo)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
newTree, err := repo.LookupTree(newTreeOID)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
commit, err := repo.CreateCommit("HEAD", signature(), signature(), "Test rebase onto, Baby! "+something, newTree, headCommit)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
opts := &CheckoutOpts{
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
Strategy: CheckoutRemoveUntracked | CheckoutForce,
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
err = repo.CheckoutIndex(index, opts)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return nil, err
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return commit, nil
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
func entryExists(repo *Repository, file string) bool {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
head, err := repo.Head()
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return false
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
headCommit, err := repo.LookupCommit(head.Target())
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return false
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
headTree, err := headCommit.Tree()
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err != nil {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return false
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
_, err = headTree.EntryByPath(file)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
return err == nil
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
func TestRebaseOnto(t *testing.T) {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
repo := createTestRepo(t)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
defer cleanupTestRepo(t, repo)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
fileInMaster := "something"
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
fileInEmile := "something else"
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
// Seed master
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
seedTestRepo(t, repo)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
// Create a new branch from master
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
err := createBranch(repo, "emile")
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
checkFatal(t, err)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
// Create a commit in master
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
_, err = commitSomething(repo, fileInMaster)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
checkFatal(t, err)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
// Switch to this emile
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
err = repo.SetHead("refs/heads/emile")
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
checkFatal(t, err)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
// Check master commit is not in emile branch
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if entryExists(repo, fileInMaster) {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
t.Fatal("something entry should not exist in emile branch")
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
// Create a commit in emile
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
_, err = commitSomething(repo, fileInEmile)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
checkFatal(t, err)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
// Rebase onto master
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
master, err := repo.LookupBranch("master", BranchLocal)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
branch, err := repo.AnnotatedCommitFromRef(master.Reference)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
checkFatal(t, err)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
rebase, err := repo.RebaseInit(nil, nil, branch, nil)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
checkFatal(t, err)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
defer rebase.Free()
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
operation, err := rebase.Next()
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
checkFatal(t, err)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
commit, err := repo.LookupCommit(operation.ID)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
checkFatal(t, err)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
err = rebase.Commit(operation.ID, signature(), signature(), commit.Message())
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
checkFatal(t, err)
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
rebase.Finish()
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
// Check master commit is now also in emile branch
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if !entryExists(repo, fileInMaster) {
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
t.Fatal("something entry should now exist in emile branch")
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
![]() Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
![]() Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
![]() The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
![]() Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming
git_repository_init()
asInitRepository()
since the namespacing in C and Go is bit different, so this should be calledInitRebase()
.We have prior art of naming
git_repository_init()
asInitRepository()
since the namespacing in C and Go is bit different, so this should be calledInitRebase()
.Like with the init function, this should be called
OpenRebase()
. The documentation shouldn't reference the C functiongit_rebase_init
but our own.Like with the init function, this should be called
OpenRebase()
. The documentation shouldn't reference the C functiongit_rebase_init
but our own.This return value does not match how Go reports errors. I would expect a
uint
to return the current operation and anerror
to return any errors.This return value does not match how Go reports errors. I would expect a
uint
to return the current operation and anerror
to return any errors.There is no
GIT_REBASE_OPERATION_EXEC
in git2go, it'sRebaseOperationExec
.There is no
GIT_REBASE_OPERATION_EXEC
in git2go, it'sRebaseOperationExec
.There is no
git_rebase_next
in git2go, we haveNext()
.There is no
git_rebase_next
in git2go, we haveNext()
.Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named
Id
.The other public id fields are named
Id
.Ok, I followed go convention suggested by my IDE plugin
Ok, I followed go convention suggested by my IDE plugin
Done
Done
Done
Done
Done
Done
Done.
I also added
ErrClassRebase
ingit.go
Hope this is correct
Done.
I also added
ErrClassRebase
ingit.go
Hope this is correct
Done
Done
Done
Done