Rebase wrapper #332

Merged
ezwiebel merged 10 commits from rebase-wrapper into master 2017-04-13 13:50:42 -05:00
2 changed files with 319 additions and 0 deletions
Showing only changes of commit b1a9de8037 - Show all commits

152
rebase.go Normal file
View File

@ -0,0 +1,152 @@
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
package git
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
/*
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
#include <git2.h>
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
*/
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
import "C"
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
import (
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
"errors"
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
"runtime"
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
"unsafe"
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// RebaseOperationType is the type of rebase operation
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
type RebaseOperationType uint
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
const (
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// RebaseOperationPick The given commit is to be cherry-picked. The client should commit the changes and continue if there are no conflicts.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
RebaseOperationPick RebaseOperationType = C.GIT_REBASE_OPERATION_PICK
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// RebaseOperationEdit The given commit is to be cherry-picked, but the client should stop to allow the user to edit the changes before committing them.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
RebaseOperationEdit RebaseOperationType = C.GIT_REBASE_OPERATION_EDIT
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// RebaseOperationSquash The given commit is to be squashed into the previous commit. The commit message will be merged with the previous message.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
RebaseOperationSquash RebaseOperationType = C.GIT_REBASE_OPERATION_SQUASH
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// RebaseOperationFixup No commit will be cherry-picked. The client should run the given command and (if successful) continue.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
RebaseOperationFixup RebaseOperationType = C.GIT_REBASE_OPERATION_FIXUP
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// RebaseOperationExec No commit will be cherry-picked. The client should run the given command and (if successful) continue.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
RebaseOperationExec RebaseOperationType = C.GIT_REBASE_OPERATION_EXEC
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// RebaseOperation describes a single instruction/operation to be performed during the rebase.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
type RebaseOperation struct {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
Type RebaseOperationType
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
ID *Oid
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
Exec string
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
func rebaseOperationFromC(c *C.git_rebase_operation) *RebaseOperation {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
operation := &RebaseOperation{}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
operation.Type = RebaseOperationType(c._type)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
operation.ID = newOidFromC(&c.id)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
operation.Exec = C.GoString(c.exec)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return operation
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// RebaseOptions are used to tell the rebase machinery how to operate
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
type RebaseOptions struct{}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// Rebase object wrapper for C pointer
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
type Rebase struct {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
ptr *C.git_rebase
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
//RebaseInit initializes a rebase operation to rebase the changes in branch relative to upstream onto another branch.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
func (r *Repository) RebaseInit(branch *AnnotatedCommit, upstream *AnnotatedCommit, onto *AnnotatedCommit, opts *RebaseOptions) (*Rebase, error) {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
runtime.LockOSThread()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
defer runtime.UnlockOSThread()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
//TODO : use real rebase_options
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if opts != nil {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return nil, errors.New("RebaseOptions Not implemented yet")
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if branch == nil {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
branch = &AnnotatedCommit{ptr: nil}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if upstream == nil {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
upstream = &AnnotatedCommit{ptr: nil}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if onto == nil {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
onto = &AnnotatedCommit{ptr: nil}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
var ptr *C.git_rebase
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
err := C.git_rebase_init(&ptr, r.ptr, branch.ptr, upstream.ptr, onto.ptr, nil)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if err < 0 {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return nil, MakeGitError(err)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return newRebaseFromC(ptr), nil
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// Next performs the next rebase operation and returns the information about it.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// If the operation is one that applies a patch (which is any operation except GIT_REBASE_OPERATION_EXEC)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// then the patch will be applied and the index and working directory will be updated with the changes.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// If there are conflicts, you will need to address those before committing the changes.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
func (rebase *Rebase) Next() (*RebaseOperation, error) {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
runtime.LockOSThread()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
defer runtime.UnlockOSThread()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
var ptr *C.git_rebase_operation
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
err := C.git_rebase_next(&ptr, rebase.ptr)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if err < 0 {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return nil, MakeGitError(err)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return rebaseOperationFromC(ptr), nil
carlosmn commented 2016-10-31 14:40:54 -05:00 (Migrated from github.com)
Review

This looks like it should have a much more generic name, since what it does is unrelated to note rewriting and it's simply mapping an empty string and NULL.

This looks like it should have a much more generic name, since what it does is unrelated to note rewriting and it's simply mapping an empty string and `NULL`.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:29 -05:00 (Migrated from github.com)
Review

I understand your point. Renamed to mapEmptyStringToNull :p

I understand your point. Renamed to mapEmptyStringToNull :p
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// Commit commits the current patch.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// You must have resolved any conflicts that were introduced during the patch application from the git_rebase_next invocation.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
func (rebase *Rebase) Commit(ID *Oid, author, committer *Signature, message string) error {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
runtime.LockOSThread()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
defer runtime.UnlockOSThread()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
authorSig, err := author.toC()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if err != nil {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return err
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
defer C.git_signature_free(authorSig)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
committerSig, err := committer.toC()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if err != nil {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return err
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
cmsg := C.CString(message)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
defer C.free(unsafe.Pointer(cmsg))
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
cerr := C.git_rebase_commit(ID.toC(), rebase.ptr, authorSig, committerSig, nil, cmsg)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if cerr < 0 {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return MakeGitError(cerr)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return nil
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
// Finish finishes a rebase that is currently in progress once all patches have been applied.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
func (rebase *Rebase) Finish() error {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
runtime.LockOSThread()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
defer runtime.UnlockOSThread()
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
err := C.git_rebase_finish(rebase.ptr, nil)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
if err < 0 {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return MakeGitError(err)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return nil
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
//Free frees the Rebase object and underlying git_rebase C pointer.
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
func (rebase *Rebase) Free() {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
runtime.SetFinalizer(rebase, nil)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
C.git_reference_free(rebase.ptr)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
func newRebaseFromC(ptr *C.git_rebase) *Rebase {
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
rebase := &Rebase{ptr: ptr}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
runtime.SetFinalizer(rebase, (*Rebase).Free)
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
return rebase
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done
}
carlosmn commented 2016-10-31 14:42:19 -05:00 (Migrated from github.com)
Review

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.

This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
carlosmn commented 2016-10-31 14:43:23 -05:00 (Migrated from github.com)
Review

We have prior art of naming git_repository_init() as InitRepository() since the namespacing in C and Go is bit different, so this should be called InitRebase().

We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
carlosmn commented 2016-10-31 14:44:06 -05:00 (Migrated from github.com)
Review

Like with the init function, this should be called OpenRebase(). The documentation shouldn't reference the C function git_rebase_init but our own.

Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
carlosmn commented 2016-10-31 14:45:41 -05:00 (Migrated from github.com)
Review

This return value does not match how Go reports errors. I would expect a uint to return the current operation and an error to return any errors.

This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
carlosmn commented 2016-10-31 14:46:46 -05:00 (Migrated from github.com)
Review

There is no GIT_REBASE_OPERATION_EXEC in git2go, it's RebaseOperationExec.

There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
carlosmn commented 2016-10-31 14:47:37 -05:00 (Migrated from github.com)
Review

There is no git_rebase_next in git2go, we have Next().

There is no `git_rebase_next` in git2go, we have `Next()`.
carlosmn commented 2016-10-31 14:50:26 -05:00 (Migrated from github.com)
Review

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.

Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
carlosmn commented 2016-10-31 14:54:32 -05:00 (Migrated from github.com)
Review

The other public id fields are named Id.

The other public id fields are named `Id`.
ezwiebel commented 2016-10-31 18:57:15 -05:00 (Migrated from github.com)
Review

Ok, I followed go convention suggested by my IDE plugin

Ok, I followed go convention suggested by my IDE plugin
ezwiebel commented 2016-10-31 18:58:38 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:42 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 18:58:49 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:02 -05:00 (Migrated from github.com)
Review

Done.
I also added ErrClassRebase in git.go
Hope this is correct

Done. I also added `ErrClassRebase` in `git.go` Hope this is correct
ezwiebel commented 2016-10-31 19:01:09 -05:00 (Migrated from github.com)
Review

Done

Done
ezwiebel commented 2016-10-31 19:01:27 -05:00 (Migrated from github.com)
Review

Done

Done

167
rebase_test.go Normal file
View File

@ -0,0 +1,167 @@
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
package git
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
import (
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
"testing"
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
"time"
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
func createBranch(repo *Repository, branch string) error {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
head, err := repo.Head()
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
commit, err := repo.LookupCommit(head.Target())
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
_, err = repo.CreateBranch(branch, commit, false)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
func signature() *Signature {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return &Signature{
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
Name: "Emile",
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
Email: "emile@emile.com",
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
When: time.Now(),
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
func commitSomething(repo *Repository, something string) (*Oid, error) {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
head, err := repo.Head()
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
headCommit, err := repo.LookupCommit(head.Target())
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
index, err := NewIndex()
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
defer index.Free()
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
blobOID, err := repo.CreateBlobFromBuffer([]byte("fou"))
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
entry := &IndexEntry{
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
Mode: FilemodeBlob,
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
Id: blobOID,
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
Path: something,
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err := index.Add(entry); err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
newTreeOID, err := index.WriteTreeTo(repo)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
newTree, err := repo.LookupTree(newTreeOID)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
commit, err := repo.CreateCommit("HEAD", signature(), signature(), "Test rebase onto, Baby! "+something, newTree, headCommit)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
opts := &CheckoutOpts{
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
Strategy: CheckoutRemoveUntracked | CheckoutForce,
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
err = repo.CheckoutIndex(index, opts)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return nil, err
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return commit, nil
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
func entryExists(repo *Repository, file string) bool {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
head, err := repo.Head()
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return false
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
headCommit, err := repo.LookupCommit(head.Target())
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return false
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
headTree, err := headCommit.Tree()
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if err != nil {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return false
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
_, err = headTree.EntryByPath(file)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
return err == nil
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
func TestRebaseOnto(t *testing.T) {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
repo := createTestRepo(t)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
defer cleanupTestRepo(t, repo)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
fileInMaster := "something"
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
fileInEmile := "something else"
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
// Seed master
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
seedTestRepo(t, repo)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
// Create a new branch from master
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
err := createBranch(repo, "emile")
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
checkFatal(t, err)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
// Create a commit in master
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
_, err = commitSomething(repo, fileInMaster)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
checkFatal(t, err)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
// Switch to this emile
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
err = repo.SetHead("refs/heads/emile")
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
checkFatal(t, err)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
// Check master commit is not in emile branch
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if entryExists(repo, fileInMaster) {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
t.Fatal("something entry should not exist in emile branch")
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
// Create a commit in emile
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
_, err = commitSomething(repo, fileInEmile)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
checkFatal(t, err)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
// Rebase onto master
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
master, err := repo.LookupBranch("master", BranchLocal)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
branch, err := repo.AnnotatedCommitFromRef(master.Reference)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
checkFatal(t, err)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
rebase, err := repo.RebaseInit(nil, nil, branch, nil)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
checkFatal(t, err)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
defer rebase.Free()
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
operation, err := rebase.Next()
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
checkFatal(t, err)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
commit, err := repo.LookupCommit(operation.ID)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
checkFatal(t, err)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
err = rebase.Commit(operation.ID, signature(), signature(), commit.Message())
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
checkFatal(t, err)
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
rebase.Finish()
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
// Check master commit is now also in emile branch
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
if !entryExists(repo, fileInMaster) {
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
t.Fatal("something entry should now exist in emile branch")
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
}
carlosmn commented 2016-10-31 14:56:01 -05:00 (Migrated from github.com)
Review

Don't hard-code 1 here, the point of the version field is to increase it.

Don't hard-code 1 here, the point of the version field is to increase it.
ezwiebel commented 2016-10-31 19:03:04 -05:00 (Migrated from github.com)
Review

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a #define or a constant that was used as default version number.
The test doesn't have great value though

Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number. The test doesn't have great value though
carlosmn commented 2016-11-13 12:33:45 -06:00 (Migrated from github.com)
Review

The version it needs to return in the version that is specified by the libgit2 headers in the #define. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.

The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
ezwiebel commented 2016-11-14 02:13:44 -06:00 (Migrated from github.com)
Review

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.

Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.