Rebase wrapper #332
|
|
@ -84,12 +84,19 @@ func (ro *RebaseOptions) toC() *C.git_rebase_options {
|
|||
|
|
||||
version: C.uint(ro.Version),
|
||||
quiet: C.int(ro.Quiet),
|
||||
inmemory: C.int(ro.InMemory),
|
||||
rewrite_notes_ref: C.CString(ro.RewriteNotesRef),
|
||||
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
|
||||
rewrite_notes_ref: rewriteNotesRefToC(ro.RewriteNotesRef),
|
||||
|
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
|
||||
merge_options: *ro.MergeOptions.toC(),
|
||||
checkout_options: *ro.CheckoutOptions.toC(),
|
||||
}
|
||||
}
|
||||
|
||||
func rewriteNotesRefToC(ref string) *C.char {
|
||||
|
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
|
||||
if ref == "" {
|
||||
|
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
|
||||
return nil
|
||||
|
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
|
||||
}
|
||||
|
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
|
||||
return C.CString(ref)
|
||||
|
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
|
||||
}
|
||||
|
This looks like it should have a much more generic name, since what it does is unrelated to note rewriting and it's simply mapping an empty string and This looks like it should have a much more generic name, since what it does is unrelated to note rewriting and it's simply mapping an empty string and `NULL`.
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
I understand your point. Renamed to mapEmptyStringToNull :p I understand your point. Renamed to mapEmptyStringToNull :p
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
|
||||
|
||||
|
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
|
||||
// Rebase object wrapper for C pointer
|
||||
type Rebase struct {
|
||||
ptr *C.git_rebase
|
||||
|
|
|
|||
|
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it. This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
We have prior art of naming We have prior art of naming `git_repository_init()` as `InitRepository()` since the namespacing in C and Go is bit different, so this should be called `InitRebase()`.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
Like with the init function, this should be called Like with the init function, this should be called `OpenRebase()`. The documentation shouldn't reference the C function `git_rebase_init` but our own.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
This return value does not match how Go reports errors. I would expect a This return value does not match how Go reports errors. I would expect a `uint` to return the current operation and an `error` to return any errors.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `GIT_REBASE_OPERATION_EXEC` in git2go, it's `RebaseOperationExec`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
There is no There is no `git_rebase_next` in git2go, we have `Next()`.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there. Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named The other public id fields are named `Id`.
The other public id fields are named The other public id fields are named `Id`.
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Ok, I followed go convention suggested by my IDE plugin Ok, I followed go convention suggested by my IDE plugin
Done Done
Done Done
Done Done
Done Done
Done Done
Done Done
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done. Done.
I also added `ErrClassRebase` in `git.go`
Hope this is correct
Done Done
Done Done
Done Done
Done Done
|
||||
|
|
@ -143,6 +143,12 @@ func TestRebaseNoConflicts(t *testing.T) {
|
|||
|
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
err = rebase.Finish()
|
||||
checkFatal(t, err)
|
||||
|
||||
// Check no more rebase is in progress
|
||||
|
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
oRebase, err = repo.RebaseOpen(nil)
|
||||
|
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
if err == nil {
|
||||
|
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
t.Fatal("Did not expect to find a rebase in progress")
|
||||
|
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
}
|
||||
|
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
|
||||
|
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
// Check history is in correct order
|
||||
actualHistory, err := commitMsgsList(repo)
|
||||
checkFatal(t, err)
|
||||
|
|
|
|||
|
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Don't hard-code 1 here, the point of the version field is to increase it. Don't hard-code 1 here, the point of the version field is to increase it.
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a Not sure how to handle this. It's a test that checks the default version returned by DefaultRebaseOptions. After a look into C code, I thought it was a `#define` or a constant that was used as default version number.
The test doesn't have great value though
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
The version it needs to return in the version that is specified by the libgit2 headers in the The version it needs to return in the version that is specified by the libgit2 headers in the `#define`. That's what the compiler is building and that's what it will use in order to figure out the size of the struct, which has to match what we're telling libgit2 we have.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think. Thanks for that. However I'm not sure how I should do as the cgo feature seems to be forbidden in tests... I will just drop this very low value test I think.
|
||||
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
This describes the structure mechanically, but almost everything is a wrapper, if we're going to have a comment here, it should describe the object itself and/or what you can do with it.
We have prior art of naming
git_repository_init()asInitRepository()since the namespacing in C and Go is bit different, so this should be calledInitRebase().We have prior art of naming
git_repository_init()asInitRepository()since the namespacing in C and Go is bit different, so this should be calledInitRebase().Like with the init function, this should be called
OpenRebase(). The documentation shouldn't reference the C functiongit_rebase_initbut our own.Like with the init function, this should be called
OpenRebase(). The documentation shouldn't reference the C functiongit_rebase_initbut our own.This return value does not match how Go reports errors. I would expect a
uintto return the current operation and anerrorto return any errors.This return value does not match how Go reports errors. I would expect a
uintto return the current operation and anerrorto return any errors.There is no
GIT_REBASE_OPERATION_EXECin git2go, it'sRebaseOperationExec.There is no
GIT_REBASE_OPERATION_EXECin git2go, it'sRebaseOperationExec.There is no
git_rebase_nextin git2go, we haveNext().There is no
git_rebase_nextin git2go, we haveNext().Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
Missing space. The pointer isn't public so let's not mention it. "unmanaged resources" covers whatever we decide to put in there.
The other public id fields are named
Id.The other public id fields are named
Id.Ok, I followed go convention suggested by my IDE plugin
Ok, I followed go convention suggested by my IDE plugin
Done
Done
Done
Done
Done
Done
Done.
I also added
ErrClassRebaseingit.goHope this is correct
Done.
I also added
ErrClassRebaseingit.goHope this is correct
Done
Done
Done
Done