libgit2 v1.5.0 #major #929

2022-09-20T06:57:36-05:00

aryan9600 commented

2022-09-20 06:57:36 -05:00

(Migrated from github.com)

Update libgit2 to v1.5.0. Replace SmartProxyOptions() with SmartRemoteConnectOptions().

Fixes: https://github.com/libgit2/git2go/issues/899

Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com

Update libgit2 to v1.5.0. Replace `SmartProxyOptions()` with `SmartRemoteConnectOptions()`. Fixes: https://github.com/libgit2/git2go/issues/899 Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>

👍 4 🎉 2

mechanicker (Migrated from github.com) reviewed 2022-10-01 10:46:39 -05:00

README.md

mechanicker (Migrated from github.com) commented

2022-10-01 10:46:39 -05:00

Should this be v33 since v34 is for 1.5?

lhchavez (Migrated from github.com) reviewed 2022-10-04 09:46:42 -05:00

lhchavez (Migrated from github.com) left a comment

yay, thanks for doing this.

README.md

lhchavez (Migrated from github.com) commented

2022-10-04 09:43:38 -05:00

it should!

| 1.3     | v33           |

it should! ```suggestion | 1.3 | v33 | ```

transport.go

													
				@ -89,2 +87,4 @@

				// SmartRemoteConnectOptions gets a copy of the proxy options for this transport.

				func (t *Transport) SmartRemoteConnectOptions() (*RemoteConnectOptions, error) {

					runtime.LockOSThread()

					defer runtime.UnlockOSThread()

lhchavez (Migrated from github.com) commented

2022-10-04 09:46:22 -05:00

// SmartRemoteConnectOptions gets a copy of the proxy options for this transport.
func (t *Transport) SmartRemoteConnectOptions() (*RemoteConnectOptions, error) {

let's keep the comment so that https://pkg.go.dev/github.com/libgit2/git2go/v34 shows more information to developers.

```suggestion // SmartRemoteConnectOptions gets a copy of the proxy options for this transport. func (t *Transport) SmartRemoteConnectOptions() (*RemoteConnectOptions, error) { ``` let's keep the comment so that https://pkg.go.dev/github.com/libgit2/git2go/v34 shows more information to developers.