jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

Generate stringer files automatically (#841) #866

Merged
lhchavez merged 1 commits from cherry-pick-5e35338d58b589939b599c98ec9e6b44f94de20a-release-1.0 into release-1.0 2021-11-09 08:48:31 -06:00
Conversation 0 Commits 1 Files Changed 3 +29
lhchavez commented 2021-11-09 08:45:11 -06:00 (Migrated from github.com)
Copy Link

Added stringer annotations to git.go for ErrorClass and
ErrorCode. Added generate rule for Makefile to generate
string representations for these types (first building cgo files
in _obj dir to get C constants). Finally, updated ci actions
workflow to check that generated files are up to date.

Fixes: #543
(cherry picked from commit 5e35338d58)

Added `stringer` annotations to `git.go` for `ErrorClass` and `ErrorCode`. Added `generate` rule for `Makefile` to generate string representations for these types (first building cgo files in `_obj` dir to get C constants). Finally, updated `ci` actions workflow to check that generated files are up to date. Fixes: #543 (cherry picked from commit 5e35338d58b589939b599c98ec9e6b44f94de20a)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#866
No description provided.
Delete Branch "cherry-pick-5e35338d58b589939b599c98ec9e6b44f94de20a-release-1.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?