Rename the build files (#724) #727

2020-12-13T17:20:39-06:00

github-actions[bot] commented

2020-12-13 17:20:39 -06:00

(Migrated from github.com)

This change renames the build files so they come lexicographically
before any source files. This makes the compile errors (due to
mismatched libgit2 versions) easier to understand, since the
Build_*.go files will be tried before the rest, and the #error in
those files will kick in, leading to a much better experience.

This unfortunately goes a bit against the defacto standard of using only
lowercase characters in filenames, but the better developer experience
(and better self-diagnosis when things go wrong instead of having to
open a new issue) is worth the deviation.

Fixes: #711
Fixes: #617
(cherry picked from commit 4b2ac7c998)

This change renames the build files so they come lexicographically before any source files. This makes the compile errors (due to mismatched libgit2 versions) easier to understand, since the `Build_*.go` files will be tried before the rest, and the `#error` in those files will kick in, leading to a much better experience. This unfortunately goes a bit against the defacto standard of using only lowercase characters in filenames, but the better developer experience (and better self-diagnosis when things go wrong instead of having to open a new issue) is worth the deviation. Fixes: #711 Fixes: #617 (cherry picked from commit 4b2ac7c998be677d865367908787f17fb570c679)

Sign in to join this conversation.

No reviewers