jcarr
/
git2go
1
0
Fork 0
Code Issues 52 Pull Requests 31 Packages Projects Releases Wiki Activity

More callback refactoring (#713) #717

Merged
github-actions[bot] merged 1 commits from cherry-pick-413302603-release-1.0 into release-1.0 2020-12-10 20:01:42 -06:00
Conversation 0 Commits 1 Files Changed 15 +453 -362
github-actions[bot] commented 2020-12-10 09:20:10 -06:00 (Migrated from github.com)
Copy Link

This change:

  • Gets rid of the .toC() functions for Options objects, since they
    were redundant with the populateXxxOptions().
  • Adds support for errorTarget to the RemoteOptions, since they are
    used in the same stack for some functions (like Fetch()). Now for
    those cases, the error returned by the callback will be preserved
    as-is.

(cherry picked from commit 10c67474a8)

This change: * Gets rid of the `.toC()` functions for Options objects, since they were redundant with the `populateXxxOptions()`. * Adds support for `errorTarget` to the `RemoteOptions`, since they are used in the same stack for some functions (like `Fetch()`). Now for those cases, the error returned by the callback will be preserved as-is. (cherry picked from commit 10c67474a89c298172a6703b91980ea37c60d5e5)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
up for grabs

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
up for grabs
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jcarr/git2go#717
No description provided.
Delete Branch "cherry-pick-413302603-release-1.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?