Create v31 to support libgit2 v1.1.x #668

2020-10-26T08:31:46-05:00

suhaibmujahid commented

2020-10-26 08:31:46 -05:00

(Migrated from github.com)

The libgit2 v1.1.0 is released two weeks ago. This PR allows git2go to link against the new version.

The libgit2 `v1.1.0` is released two weeks ago. This PR allows `git2go` to link against the new version.

lhchavez (Migrated from github.com) reviewed 2020-10-26 20:09:10 -05:00

lhchavez (Migrated from github.com) left a comment

Thanks! :D

suhaibmujahid commented

2020-10-26 20:28:52 -05:00

(Migrated from github.com)

Thank you for merging this.

I think the automatically generated version tag is not correct.

See here: https://github.com/libgit2/git2go/releases/tag/v30.0.19

It should be v31 not v30. I think it should be deleted to not crash for ppl that depend on the older libgit2 version.

Based on the documentation of the action that we are using:
https://github.com/anothrNick/github-tag-action#bumping
I supposed to include #major in the commit message to bump a major version.

Thank you for merging this. I think the automatically generated version tag is not correct. See here: https://github.com/libgit2/git2go/releases/tag/v30.0.19 It should be v31 not v30. I think it should be deleted to not crash for ppl that depend on the older `libgit2` version. Based on the documentation of the action that we are using: https://github.com/anothrNick/github-tag-action#bumping I supposed to include `#major` in the commit message to bump a major version.

lhchavez commented

2020-10-26 20:39:28 -05:00

(Migrated from github.com)

Thank you for merging this.

I think the automatically generated version tag is not correct.

See here: https://github.com/libgit2/git2go/releases/tag/v30.0.19

It should be v31 not v30. I think it should be deleted to not crash for ppl that depend on the older libgit2 version.

Based on the documentation of the action that we are using:
https://github.com/anothrNick/github-tag-action#bumping
I supposed to include #major in the commit message to bump a major version.

oops, thanks for noticing! new tags and the new release-1.1 branch have been created.

> Thank you for merging this. > > I think the automatically generated version tag is not correct. > > See here: https://github.com/libgit2/git2go/releases/tag/v30.0.19 > > It should be v31 not v30. I think it should be deleted to not crash for ppl that depend on the older `libgit2` version. > > Based on the documentation of the action that we are using: > https://github.com/anothrNick/github-tag-action#bumping > I supposed to include `#major` in the commit message to bump a major version. oops, thanks for noticing! new tags and the new `release-1.1` branch have been created.

👍 1

suhaibmujahid commented

2020-10-26 20:46:59 -05:00

(Migrated from github.com)

Thank you for the fast response.

I believe that the tag v30.0.19 should be deleted (or create v30.0.20 on the commit f83530b18d). Otherwise when someone updates or installs v30, by default will get v30.0.19 which depends on an unexpected libgit2 version.

Thank you for the fast response. I believe that the tag v30.0.19 should be deleted (or create v30.0.20 on the commit https://github.com/libgit2/git2go/commit/f83530b18dc46867ed06fc261b309b8b545a3b6f). Otherwise when someone updates or installs `v30`, by default will get v30.0.19 which depends on an unexpected `libgit2` version.

lhchavez commented

2020-10-26 21:16:40 -05:00

(Migrated from github.com)

Thank you for the fast response.

I believe that the tag v30.0.19 should be deleted (or create v30.0.20 on the commit f83530b). Otherwise when someone updates or installs v30, by default will get v30.0.19 which depends on an unexpected libgit2 version.

the tag was also deleted when the v31 tag was created. the only thing left was the github release, which is not a real tag (but that's also removed now to avoid confusion)

> Thank you for the fast response. > > I believe that the tag v30.0.19 should be deleted (or create v30.0.20 on the commit [f83530b](https://github.com/libgit2/git2go/commit/f83530b18dc46867ed06fc261b309b8b545a3b6f)). Otherwise when someone updates or installs `v30`, by default will get v30.0.19 which depends on an unexpected `libgit2` version. the tag was also deleted when the v31 tag was created. the only thing left was the github release, which is not a real tag (but that's also removed now to avoid confusion)

Sign in to join this conversation.

No reviewers